chore: clippy -fix

Author: ovr

rust/cubesql/cubesql/src/compile/engine/df/optimizers/filter_push_down.rs

@@ -576,34 +576,32 @@ fn rewrite_map_for_projection(
         .collect()
 }
 
-/// Generates a rewrite map for union inputs, taking UNION's schema and one of the input's schema.
-/// These expressions can't be more complex than simple column references by definition.
-///
-/// TODO: see `LogicalPlan::Union` above
-/*
-fn rewrite_map_for_union_input(
-    union_schema: &DFSchema,
-    input_schema: &DFSchema,
-) -> HashMap<Column, Option<Expr>> {
-    union_schema
-        .fields()
-        .iter()
-        .zip(input_schema.fields().iter())
-        .flat_map(|(union_field, input_field)| {
-            vec![
-                (
-                    union_field.qualified_column(),
-                    Some(Expr::Column(input_field.unqualified_column())),
-                ),
-                (
-                    union_field.unqualified_column(),
-                    Some(Expr::Column(input_field.unqualified_column())),
-                ),
-            ]
-        })
-        .collect()
-}
-*/
+// /// Generates a rewrite map for union inputs, taking UNION's schema and one of the input's schema.
+// /// These expressions can't be more complex than simple column references by definition.
+// ///
+// /// TODO: see `LogicalPlan::Union` above
+// fn rewrite_map_for_union_input(
+//     union_schema: &DFSchema,
+//     input_schema: &DFSchema,
+// ) -> HashMap<Column, Option<Expr>> {
+//     union_schema
+//         .fields()
+//         .iter()
+//         .zip(input_schema.fields().iter())
+//         .flat_map(|(union_field, input_field)| {
+//             vec![
+//                 (
+//                     union_field.qualified_column(),
+//                     Some(Expr::Column(input_field.unqualified_column())),
+//                 ),
+//                 (
+//                     union_field.unqualified_column(),
+//                     Some(Expr::Column(input_field.unqualified_column())),
+//                 ),
+//             ]
+//         })
+//         .collect()
+// }
 
 /// Recursively concatenates several filter predicates into one binary AND expression.
 /// `predicates` must contain at least one expression.
@@ -621,24 +619,22 @@ fn concatenate_predicates(predicates: Vec<Expr>) -> Result<Expr> {
         ))
 }
 
-/// Recursively splits filter predicate from binary AND expressions into a flat vec of predicates.
-///
-/// TODO: see `LogicalPlan::Filter` above
-/*
-fn split_predicates(predicate: &Expr) -> Vec<Expr> {
-    match predicate {
-        Expr::BinaryExpr {
-            left,
-            op: Operator::And,
-            right,
-        } => split_predicates(left)
-            .into_iter()
-            .chain(split_predicates(right).into_iter())
-            .collect(),
-        expr => vec![expr.clone()],
-    }
-}
-*/
+// /// Recursively splits filter predicate from binary AND expressions into a flat vec of predicates.
+// ///
+// /// TODO: see `LogicalPlan::Filter` above
+// fn split_predicates(predicate: &Expr) -> Vec<Expr> {
+//     match predicate {
+//         Expr::BinaryExpr {
+//             left,
+//             op: Operator::And,
+//             right,
+//         } => split_predicates(left)
+//             .into_iter()
+//             .chain(split_predicates(right).into_iter())
+//             .collect(),
+//         expr => vec![expr.clone()],
+//     }
+// }
 
 /// Recursively checks if the passed expr is a filter predicate that can be pushed down.
 /// The predicate should be pushed down the plan if it can ultimately be pushed down to CubeScan.

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

@@ -386,7 +386,7 @@ pub fn is_const_expr(expr: &Expr) -> bool {
             _ => false,
         },
         Expr::InList { expr, list, .. } => {
-            is_const_expr(expr) && list.iter().map(|item| is_const_expr(item)).all(|item| item)
+            is_const_expr(expr) && list.iter().all(|item| is_const_expr(item))
         }
         _ => false,
     }

rust/cubesql/cubesql/src/compile/engine/variable_provider.rs

@@ -25,7 +25,7 @@ impl VariablesProvider {
 
     fn get_session_value(&self, identifier: Vec<String>, var_type: VarType) -> Result<ScalarValue> {
         let key = if identifier.len() > 1 {
-            let ignore_first = identifier[0].to_ascii_lowercase() == "@@session";
+            let ignore_first = identifier[0].eq_ignore_ascii_case("@@session");
             if ignore_first {
                 identifier[1..].concat()
             } else {
@@ -48,7 +48,7 @@ impl VariablesProvider {
 
     fn get_global_value(&self, identifier: Vec<String>) -> Result<ScalarValue> {
         let key = if identifier.len() > 1 {
-            let ignore_first = identifier[0].to_ascii_lowercase() == "@@global";
+            let ignore_first = identifier[0].eq_ignore_ascii_case("@@global");
 
             if ignore_first {
                 identifier[1..].concat()
@@ -85,7 +85,7 @@ impl VarProvider for VariablesProvider {
 
         match (&first_word_vec[0], &first_word_vec[1]) {
             ('@', '@') => {
-                if identifier.len() > 1 && identifier[0].to_ascii_lowercase() == "@@session" {
+                if identifier.len() > 1 && identifier[0].eq_ignore_ascii_case("@@session") {
                     return self.get_session_value(identifier, VarType::System);
                 }