Skip to content

Commit 143cfe5

Browse files
committed
wip: implement self.select_distinct_dimensions()
1 parent 57432b8 commit 143cfe5

File tree

1 file changed

+10
-4
lines changed
  • rust/cubesql/cubesql/src/compile/rewrite/rules

1 file changed

+10
-4
lines changed

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ impl RewriteRules for MemberRules {
288288
"CubeScanWrapped:false",
289289
"CubeScanUngrouped:false",
290290
),
291-
self.select_distinct_dimensions("?members", "?limit"),
291+
self.select_distinct_dimensions(/*"?members",*/ "?limit"),
292292
),
293293
// MOD function to binary expr
294294
transforming_rewrite_with_root(
@@ -1508,10 +1508,10 @@ impl MemberRules {
15081508

15091509
fn select_distinct_dimensions(
15101510
&self,
1511-
members_var: &'static str,
1511+
// members_var: &'static str,
15121512
limit_var: &'static str,
15131513
) -> impl Fn(&mut CubeEGraph, &mut Subst) -> bool {
1514-
let members_var = var!(members_var);
1514+
// let members_var = var!(members_var);
15151515
let limit_var = var!(limit_var);
15161516

15171517
move |egraph, subst| {
@@ -1523,7 +1523,13 @@ impl MemberRules {
15231523
return false;
15241524
}
15251525

1526-
for members in var_list_iter!(egraph[subst[members_var]], CubeScanMembers) {}
1526+
// for members in var_list_iter!(egraph[subst[members_var]], CubeScanMembers) {
1527+
// // TODO: check if all members in request are dimensions
1528+
// // If no - return false
1529+
// for member in members.iter() {
1530+
// println!("member: {:?}", egraph[*member]);
1531+
// }
1532+
// }
15271533

15281534
true
15291535
}

0 commit comments

Comments
 (0)