Skip to content

Commit 148fb96

Browse files
ovrovr
authored
fix(server-core): Specify maximum for continueWaitTimeout (90 seconds) (#7301)
1 parent 1e722dd commit 148fb96

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

‎docs/content/Reference/Configuration/Config.mdx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -711,8 +711,8 @@ these values can result in application instability and/or downtime.
711711
You can pass this object to set advanced options for Cube Query Orchestrator.
712712

713713
| Option | Description | Default Value |
714-
| -------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------- |
715-
| continueWaitTimeout | Long polling interval | `5` |
714+
|----------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------|
715+
| continueWaitTimeout | Long polling interval in seconds, maximum is 90 | `5` |
716716
| redisPrefix | Prefix to be set an all Redis keys | `STANDALONE` |
717717
| rollupOnlyMode | When enabled, an error will be thrown if a query can't be served from a pre-aggregation (rollup) | `false` |
718718
| queryCacheOptions | Query cache options for DB queries | `{}` |

‎docs/docs-new/pages/reference/configuration/config.mdx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,8 @@ these values can result in application instability and/or downtime.
441441
You can pass this object to set advanced options for the query orchestrator.
442442

443443
| Option | Description | Default Value |
444-
| -------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------- |
445-
| continueWaitTimeout | Long polling interval | `5` |
444+
|----------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------|
445+
| continueWaitTimeout | Long polling interval in seconds, maximum is 90 | `5` |
446446
| rollupOnlyMode | When enabled, an error will be thrown if a query can't be served from a pre-aggregation (rollup) | `false` |
447447
| queryCacheOptions | Query cache options for DB queries | `{}` |
448448
| queryCacheOptions.refreshKeyRenewalThreshold | Time in seconds to cache the result of [`refresh_key`][ref-schema-cube-ref-refresh-key] check | `defined by DB dialect` |
@@ -479,7 +479,7 @@ Timeout and interval options' values are in seconds.
479479
from cube import config
480480

481481
config.orchestrator_options = {
482-
'continueWaitTimeout': 1000,
482+
'continueWaitTimeout': 10,
483483
'rollupOnlyMode': False,
484484
'queryCacheOptions': {
485485
'refreshKeyRenewalThreshold': 30,
@@ -507,7 +507,7 @@ config.orchestrator_options = {
507507
```javascript
508508
module.exports = {
509509
orchestratorOptions: {
510-
continueWaitTimeout: 1000,
510+
continueWaitTimeout: 10,
511511
rollupOnlyMode: false,
512512
queryCacheOptions: {
513513
refreshKeyRenewalThreshold: 30,

‎packages/cubejs-server-core/src/core/optionsValidate.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import DriverDependencies from './DriverDependencies';
33

44
const schemaQueueOptions = Joi.object().strict(true).keys({
55
concurrency: Joi.number().min(1).integer(),
6-
continueWaitTimeout: Joi.number().min(0).integer(),
6+
continueWaitTimeout: Joi.number().min(0).max(90).integer(),
77
executionTimeout: Joi.number().min(0).integer(),
88
orphanedTimeout: Joi.number().min(0).integer(),
99
heartBeatInterval: Joi.number().min(0).integer(),
@@ -128,7 +128,7 @@ const schemaOptions = Joi.object().keys({
128128
idleTimeoutMillis: Joi.number().min(0),
129129
})
130130
}),
131-
continueWaitTimeout: Joi.number().min(0).integer(),
131+
continueWaitTimeout: Joi.number().min(0).max(90).integer(),
132132
skipExternalCacheAndQueue: Joi.boolean(),
133133
queryCacheOptions: Joi.object().keys({
134134
refreshKeyRenewalThreshold: Joi.number().min(0).integer(),

0 commit comments

Comments
 (0)