small update in getThreadsCount

KSDaemon · KSDaemon · commit 1872bdc351a1 · 2025-04-10T17:53:44.000+03:00
diff --git a/packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.js b/packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.js
@@ -30,7 +30,8 @@ const getThreadsCount = () => {
 
   const cpuCount = os.cpus()?.length;
   if (cpuCount) {
-    return Math.max(1, cpuCount - 1);
+    // there's no practical boost above 5 threads even if you have more cores.
+    return Math.min(Math.max(1, cpuCount - 1), 5);
   }
 
   return 3; // Default (like the workerpool do)

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,8 @@ const getThreadsCount = () => {`
`30`	`30`
`31`	`31`	`const cpuCount = os.cpus()?.length;`
`32`	`32`	`if (cpuCount) {`
`33`		`- return Math.max(1, cpuCount - 1);`
	`33`	`+ // there's no practical boost above 5 threads even if you have more cores.`
	`34`	`+ return Math.min(Math.max(1, cpuCount - 1), 5);`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`return 3; // Default (like the workerpool do)`