refactor(schema-compiler): Make joinHintFromPath static

Author: mcheshkov

packages/cubejs-schema-compiler/src/adapter/BaseDimension.ts

@@ -1,5 +1,6 @@
 import type { BaseQuery } from './BaseQuery';
 import type { DimensionDefinition, SegmentDefinition } from '../compiler/CubeEvaluator';
+import { CubeSymbols } from "../compiler/CubeSymbols";
 
 export class BaseDimension {
   public readonly expression: any;
@@ -26,7 +27,7 @@ export class BaseDimension {
       // TODO move this `as` to static types
       const dimensionPath = dimension as string | null;
       if (dimensionPath !== null) {
-        const { path, joinHint } = this.query.cubeEvaluator.joinHintFromPath(dimensionPath);
+        const { path, joinHint } = CubeSymbols.joinHintFromPath(dimensionPath);
         this.dimension = path;
         this.joinHint = joinHint;
       }

packages/cubejs-schema-compiler/src/adapter/BaseMeasure.ts

@@ -1,6 +1,7 @@
 import { UserError } from '../compiler/UserError';
 import type { BaseQuery } from './BaseQuery';
 import { MeasureDefinition } from '../compiler/CubeEvaluator';
+import { CubeSymbols } from "../compiler/CubeSymbols";
 
 export class BaseMeasure {
   public readonly expression: any;
@@ -128,7 +129,7 @@ export class BaseMeasure {
     } else {
       // TODO move this `as` to static types
       const measurePath = measure as string;
-      const { path, joinHint } = this.query.cubeEvaluator.joinHintFromPath(measurePath);
+      const { path, joinHint } = CubeSymbols.joinHintFromPath(measurePath);
       this.measure = path;
       this.joinHint = joinHint;
     }

packages/cubejs-schema-compiler/src/adapter/BaseSegment.ts

@@ -1,4 +1,5 @@
 import type { BaseQuery } from './BaseQuery';
+import { CubeSymbols } from "../compiler/CubeSymbols";
 
 export class BaseSegment {
   public readonly expression: any;
@@ -24,7 +25,7 @@ export class BaseSegment {
     } else {
       // TODO move this `as` to static types
       const segmentPath = segment as string;
-      const { path, joinHint } = this.query.cubeEvaluator.joinHintFromPath(segmentPath);
+      const { path, joinHint } = CubeSymbols.joinHintFromPath(segmentPath);
       this.segment = path;
       this.joinHint = joinHint;
     }

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

@@ -1,6 +1,7 @@
 import R from 'ramda';
 import { FROM_PARTITION_RANGE, getEnv, TO_PARTITION_RANGE } from '@cubejs-backend/shared';
 
+import { CubeSymbols } from "../compiler/CubeSymbols";
 import { UserError } from '../compiler/UserError';
 
 export class PreAggregations {
@@ -173,7 +174,7 @@ export class PreAggregations {
 
         // timeDimensionsReference[*].dimension can contain full join path, so we should trim it
         // TODO check full join path match here
-        const timeDimensionReferenceDimension = this.query.cubeEvaluator.joinHintFromPath(timeDimensionReference.dimension).path;
+        const timeDimensionReferenceDimension = CubeSymbols.joinHintFromPath(timeDimensionReference.dimension).path;
 
         if (td.dimension === timeDimensionReferenceDimension) {
           return true;
@@ -1095,7 +1096,7 @@ export class PreAggregations {
         !!references.dimensions.find((d) => {
           // `d` can contain full join path, so we should trim it
           // TODO check full join path match here
-          const trimmedDimension = this.query.cubeEvaluator.joinHintFromPath(d).path;
+          const trimmedDimension = CubeSymbols.joinHintFromPath(d).path;
           return this.query.cubeEvaluator.dimensionByPath(trimmedDimension).primaryKey;
         }),
     });

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

@@ -656,7 +656,7 @@ export class CubeSymbols {
    * Split join path to member to join hint and member path: `A.B.C.D.E.dim` => `[A, B, C, D, E]` + `E.dim`
    * @param path
    */
-  public joinHintFromPath(path: string): { path: string, joinHint: Array<string> } {
+  public static joinHintFromPath(path: string): { path: string, joinHint: Array<string> } {
     const parts = path.split('.');
     if (parts.length > 2) {
       // Path contains join path