Skip to content

Commit 1b4b6e5

Browse files
committed
added todo
1 parent 1cb5550 commit 1b4b6e5

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ export class QueryCache {
596596
},
597597
query: async (req, setCancelHandle) => {
598598
const client = await clientFactory();
599-
599+
600600
const resultPromise = executeFn(client, req);
601601
let handle;
602602
if (resultPromise.cancel) {

packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -442,6 +442,8 @@ export class QueryOrchestrator {
442442
private createMetadataQuery(operation: string, params: Record<string, any>): QueryWithParams {
443443
return [
444444
`METADATA:${operation}`,
445+
// TODO: Metadata queries need object params like [{ schema, table }]
446+
// but QueryWithParams expects string[]. This forces JSON.stringify workaround.
445447
[JSON.stringify(params)],
446448
{ external: false, renewalThreshold: 24 * 60 * 60 }
447449
];

0 commit comments

Comments
 (0)