chore(server-core): move driver deps to ts

Author: KSDaemon

packages/cubejs-server-core/src/core/DevServer.ts

@@ -326,11 +326,11 @@ export class DevServer {
     app.get('/playground/driver', catchErrors(async (req: Request, res: Response) => {
       const { driver } = req.query;
 
-      if (!driver || !DriverDependencies[driver]) {
+      if (!driver || typeof driver !== 'string' || !DriverDependencies[driver as keyof typeof DriverDependencies]) {
         return res.status(400).json('Wrong driver');
       }
 
-      if (packageExists(DriverDependencies[driver])) {
+      if (packageExists(DriverDependencies[driver as keyof typeof DriverDependencies])) {
         return res.json({ status: 'installed' });
       } else if (driverPromise) {
         return res.json({ status: 'installing' });
@@ -347,17 +347,19 @@ export class DevServer {
     app.post('/playground/driver', catchErrors((req, res) => {
       const { driver } = req.body;
 
-      if (!DriverDependencies[driver]) {
+      if (!driver || typeof driver !== 'string' || !DriverDependencies[driver as keyof typeof DriverDependencies]) {
         return res.status(400).json(`'${driver}' driver dependency not found`);
       }
 
+      const driverKey = driver as keyof typeof DriverDependencies;
+
       async function installDriver() {
         driverError = null;
 
         try {
           await executeCommand(
             'npm',
-            ['install', DriverDependencies[driver], '--save-dev'],
+            ['install', DriverDependencies[driverKey], '--save-dev'],
             { cwd: path.resolve('.') }
           );
         } catch (error) {
@@ -372,7 +374,7 @@ export class DevServer {
       }
 
       return res.json({
-        dependency: DriverDependencies[driver]
+        dependency: DriverDependencies[driverKey]
       });
     }));
 

packages/cubejs-server-core/src/core/DriverDependencies.js renamed to packages/cubejs-server-core/src/core/DriverDependencies.ts

@@ -1,4 +1,6 @@
-module.exports = {
+import { DatabaseType } from './types';
+
+const DriverDependencies: Record<DatabaseType, string> = {
   postgres: '@cubejs-backend/postgres-driver',
   mysql: '@cubejs-backend/mysql-driver',
   mysqlauroraserverless: '@cubejs-backend/mysql-aurora-serverless-driver',
@@ -31,3 +33,5 @@ module.exports = {
   // List for JDBC drivers
   'databricks-jdbc': '@cubejs-backend/databricks-jdbc-driver',
 };
+
+export default DriverDependencies;

packages/cubejs-server-core/src/core/types.ts

@@ -108,17 +108,24 @@ export type DatabaseType =
   | 'mongobi'
   | 'mssql'
   | 'mysql'
+  | 'mysqlauroraserverless'
   | 'elasticsearch'
   | 'awselasticsearch'
   | 'oracle'
   | 'postgres'
   | 'prestodb'
+  | 'trino'
   | 'redshift'
   | 'snowflake'
   | 'sqlite'
   | 'questdb'
   | 'materialize'
-  | 'pinot';
+  | 'pinot'
+  | 'dremio'
+  | 'duckdb'
+  | 'ksql'
+  | 'vertica'
+  | 'databricks-jdbc';
 
 export type ContextToAppIdFn = (context: RequestContext) => string | Promise<string>;
 export type ContextToRolesFn = (context: RequestContext) => string[] | Promise<string[]>;