Skip to content

Commit 1beb861

Browse files
committed
skip namings fix
1 parent c8c03c1 commit 1beb861

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

packages/cubejs-schema-compiler/test/integration/postgres/multiple-join-paths.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -627,8 +627,8 @@ describe('Multiple join paths', () => {
627627
}
628628
});
629629
} else {
630-
it.skip('FIXME(tesseract): This should be implemented in Tesseract.', async () => {
631-
// Skipping because it not works in Tesseract yet
630+
it.skip(`FIXME(tesseract): pre-aggregation ${preAggregationId} should match its own references`, async () => {
631+
// This should be implemented in Tesseract.
632632
});
633633
}
634634

@@ -648,8 +648,8 @@ describe('Multiple join paths', () => {
648648
expect(res).toEqual(expectedData);
649649
});
650650
} else {
651-
it.skip('FIXME(tesseract): This should be implemented in Tesseract.', async () => {
652-
// Skipping because it not works in Tesseract yet
651+
it.skip(`FIXME(tesseract): pre-aggregation ${preAggregationId} reference query should be executable`, async () => {
652+
// This should be implemented in Tesseract.
653653
});
654654
}
655655
}

packages/cubejs-schema-compiler/test/integration/postgres/pre-aggregations.test.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -570,8 +570,8 @@ describe('PreAggregations', () => {
570570
});
571571

572572
if (getEnv('nativeSqlPlanner')) {
573-
it.skip('FIXME(tesseract): Should work after fallback for pre-aggregations is fully turned off.', () => {
574-
// Skipping because it not works in Tesseract yet
573+
it.skip('FIXME(tesseract): simple pre-aggregation proxy time dimension', () => {
574+
// Should work after fallback for pre-aggregations is fully turned off
575575
});
576576
/* it('simple pre-aggregation proxy time dimension', () => compiler.compile().then(() => {
577577
const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
@@ -1121,8 +1121,9 @@ describe('PreAggregations', () => {
11211121
});
11221122
});
11231123
} else {
1124-
it.skip('FIXME(tesseract): This should be fixed in Tesseract.', async () => {
1125-
// Skipping because it not works in Tesseract yet
1124+
it.skip('FIXME(tesseract): multiplied measure no match', async () => {
1125+
// This should be fixed in Tesseract.
1126+
11261127
});
11271128
}
11281129

packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3496,8 +3496,8 @@ SELECT 1 AS revenue, cast('2024-01-01' AS timestamp) as time UNION ALL
34963496
}]
34973497
));
34983498
} else {
3499-
it.skip('FIXME(tesseract): Should be fixed in tesseract', () => {
3500-
// Skipping because it not works in Tesseract yet
3499+
it.skip('FIXME(tesseract): multi stage revenue_sum_group_by_granularity and group by td with granularity', () => {
3500+
// Should be fixed in tesseract
35013501
});
35023502
}
35033503

0 commit comments

Comments
 (0)