Skip to content

Commit 1d5e4f9

Browse files
committed
remove unused/unneeded
1 parent 7b1a51e commit 1d5e4f9

File tree

3 files changed

+2
-30
lines changed

3 files changed

+2
-30
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseTimeDimension.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,9 @@ export class BaseTimeDimension extends BaseFilter {
229229
);
230230
}
231231

232-
protected rollupGranularityValue: any | null = null;
232+
protected rollupGranularityValue: string | null = null;
233233

234-
public rollupGranularity() {
234+
public rollupGranularity(): string | null {
235235
if (!this.rollupGranularityValue) {
236236
this.rollupGranularityValue =
237237
this.query.cacheValue(

packages/cubejs-schema-compiler/src/adapter/Granularity.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,6 @@ export class Granularity {
109109
return timeSeriesFromCustomInterval(this.granularityInterval, dateRange, moment(this.originLocalFormatted()), options);
110110
}
111111

112-
public resolvedGranularity(): string {
113-
if (this.predefinedGranularity) {
114-
return this.granularity;
115-
}
116-
117-
return this.granularityFromInterval();
118-
}
119-
120112
/**
121113
* Returns the smallest granularity for the granularityInterval
122114
*/

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -501,26 +501,6 @@ export class PreAggregations {
501501
);
502502
}
503503

504-
canUsePreAggregationAndCheckIfRefValid(query) {
505-
const transformedQuery = PreAggregations.transformQueryToCanUseForm(query);
506-
return (refs) => PreAggregations.canUsePreAggregationForTransformedQueryFn(
507-
transformedQuery, refs
508-
);
509-
}
510-
511-
checkAutoRollupPreAggregationValid(refs) {
512-
try {
513-
this.autoRollupPreAggregationQuery(null, refs); // TODO null
514-
return true;
515-
} catch (e) {
516-
if (e instanceof UserError || e.toString().indexOf('ReferenceError') !== -1) {
517-
return false;
518-
} else {
519-
throw e;
520-
}
521-
}
522-
}
523-
524504
/**
525505
* Returns function to determine whether pre-aggregation can be used or not
526506
* for specified query, or its value for `refs` if specified.

0 commit comments

Comments
 (0)