Skip to content

Commit 1de1cb7

Browse files
committed
fix(cubesql): Allow to push LIMIT 0 to CubeScan
1 parent 80bce2e commit 1de1cb7

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1583,17 +1583,13 @@ impl MemberRules {
15831583

15841584
let mut skip_value = None;
15851585
for skip in var_iter!(egraph[subst[skip_var]], LimitSkip) {
1586-
if skip.unwrap_or_default() > 0 {
1587-
skip_value = *skip;
1588-
break;
1589-
}
1586+
skip_value = *skip;
1587+
break;
15901588
}
15911589
let mut fetch_value = None;
15921590
for fetch in var_iter!(egraph[subst[fetch_var]], LimitFetch) {
1593-
if fetch.unwrap_or_default() > 0 {
1594-
fetch_value = *fetch;
1595-
break;
1596-
}
1591+
fetch_value = *fetch;
1592+
break;
15971593
}
15981594

15991595
let mut inner_skip_value = None;

rust/cubesql/cubesql/src/compile/test/test_wrapper.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1031,7 +1031,7 @@ async fn select_agg_where_false() {
10311031
segments: Some(vec![]),
10321032
dimensions: Some(vec![]),
10331033
order: Some(vec![]),
1034-
limit: None,
1034+
limit: Some(0),
10351035
ungrouped: Some(true),
10361036
..Default::default()
10371037
}

0 commit comments

Comments
 (0)