Fix lint

Author: paco-valdez

packages/cubejs-schema-compiler/src/parser/SqlParser.ts

@@ -87,28 +87,23 @@ export class SqlParser {
           openChar = null;
         }
         result += sql[i];
-      } else {
+      } else if (sql[i] === '-' && sql[i + 1] === '-') {
         // Check for start of single-line comment
-        if (sql[i] === '-' && sql[i + 1] === '-') {
-          inComment = true;
-          commentType = '--';
-          result += sql[i];
-        }
+        inComment = true;
+        commentType = '--';
+        result += sql[i];
+      } else if (sql[i] === '/' && sql[i + 1] === '*') {
         // Check for start of multi-line comment
-        else if (sql[i] === '/' && sql[i + 1] === '*') {
-          inComment = true;
-          commentType = '/*';
-          result += sql[i];
-        }
+        inComment = true;
+        commentType = '/*';
+        result += sql[i];
+      } else if (sql[i] === '\'' || sql[i] === '"' || sql[i] === '`') {
         // Check for string literals
-        else if (sql[i] === '\'' || sql[i] === '"' || sql[i] === '`') {
-          openChar = sql[i];
-          result += sql[i].toUpperCase();
-        }
+        openChar = sql[i];
+        result += sql[i].toUpperCase();
+      } else {
         // Regular character - convert to uppercase
-        else {
-          result += sql[i].toUpperCase();
-        }
+        result += sql[i].toUpperCase();
       }
     }
 

packages/cubejs-schema-compiler/test/unit/sql-parser.test.ts

@@ -104,7 +104,7 @@ describe('SqlParser', () => {
   });
 
   it('sql with regex containing question mark', () => {
-    const sqlParser = new SqlParser("SELECT * FROM users WHERE name = ? AND REGEXP '^stripe(?!_direct).{1,}$'");
+    const sqlParser = new SqlParser('SELECT * FROM users WHERE name = ? AND REGEXP \'^stripe(?!_direct).{1,}$\'');
     expect(sqlParser.canParse()).toEqual(true);
   });