Skip to content

Commit 214a45a

Browse files
committed
[WIP][FIXUP] double remapping during patch measure extraction
1 parent 2b9159c commit 214a45a

File tree

1 file changed

+11
-10
lines changed
  • rust/cubesql/cubesql/src/compile/engine/df

1 file changed

+11
-10
lines changed

rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1670,27 +1670,28 @@ impl CubeScanWrapperNode {
16701670
let mut other = vec![];
16711671

16721672
for original_expr in exprs {
1673-
let (expr, alias) = Self::remap_column_expression(
1674-
schema,
1675-
&original_expr,
1676-
column_remapping,
1677-
next_remapper,
1678-
can_rename_columns,
1679-
)?;
1680-
16811673
let (patch_def, sql_query_next) = Self::get_patch_measure(
16821674
sql_query,
16831675
sql_generator.clone(),
1684-
&expr,
1676+
&original_expr,
16851677
push_to_cube_context,
16861678
subqueries.clone(),
16871679
)
16881680
.await?;
16891681
sql_query = sql_query_next;
16901682
if let Some((patch_def, cube)) = patch_def {
1683+
// TODO is this ok w.r.t. `_expr`
1684+
let (_expr, alias) = Self::remap_column_expression(
1685+
schema,
1686+
&original_expr,
1687+
column_remapping,
1688+
next_remapper,
1689+
can_rename_columns,
1690+
)?;
1691+
16911692
patches.push((patch_def, cube, alias));
16921693
} else {
1693-
other.push(expr);
1694+
other.push(original_expr);
16941695
}
16951696
}
16961697

0 commit comments

Comments
 (0)