Skip to content

Commit 2161227

Browse files
authored
fix(cubejs-schema-compiler): cube level public should take precedence over dimension level public (#7005)
1 parent 1f2443c commit 2161227

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

packages/cubejs-schema-compiler/src/compiler/CubeToMetaTransformer.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,11 @@ export class CubeToMetaTransformer {
3232
*/
3333
transform(cube) {
3434
const cubeTitle = cube.title || this.titleize(cube.name);
35+
36+
const isCubeVisible = this.isVisible(cube, true);
3537

3638
return {
37-
isVisible: this.isVisible(cube, true),
39+
isVisible: isCubeVisible,
3840
config: {
3941
name: cube.name,
4042
type: cube.isView ? 'view' : 'cube',
@@ -44,7 +46,7 @@ export class CubeToMetaTransformer {
4446
measures: R.compose(
4547
R.map((nameToMetric) => ({
4648
...this.measureConfig(cube.name, cubeTitle, nameToMetric),
47-
isVisible: this.isVisible(nameToMetric[1], this.isVisible(cube, true))
49+
isVisible: isCubeVisible ? this.isVisible(nameToMetric[1], true) : false
4850
})),
4951
R.toPairs
5052
)(cube.measures || {}),
@@ -59,7 +61,7 @@ export class CubeToMetaTransformer {
5961
nameToDimension[1].suggestFilterValues == null ? true : nameToDimension[1].suggestFilterValues,
6062
format: nameToDimension[1].format,
6163
meta: nameToDimension[1].meta,
62-
isVisible: this.isVisible(nameToDimension[1], this.isVisible(cube, !nameToDimension[1].primaryKey))
64+
isVisible: isCubeVisible ? this.isVisible(nameToDimension[1], !nameToDimension[1].primaryKey) : false
6365
})),
6466
R.toPairs
6567
)(cube.dimensions || {}),
@@ -70,7 +72,7 @@ export class CubeToMetaTransformer {
7072
shortTitle: this.title(cubeTitle, nameToSegment, true),
7173
description: nameToSegment[1].description,
7274
meta: nameToSegment[1].meta,
73-
isVisible: this.isVisible(nameToSegment[1], this.isVisible(cube, true))
75+
isVisible: isCubeVisible ? this.isVisible(nameToSegment[1], true) : false
7476
})),
7577
R.toPairs
7678
)(cube.segments || {})

0 commit comments

Comments
 (0)