Skip to content

Commit 230567b

Browse files
committed
in work
1 parent 493963e commit 230567b

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

rust/cubesqlplanner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ mod compiled_pre_aggregation;
22
mod dimension_matcher;
33
mod measure_matcher;
44
mod optimizer;
5-
//mod original_sql_collector;
5+
mod original_sql_collector;
66
//mod original_sql_optimizer;
77
mod pre_aggregations_compiler;
88

99
pub use compiled_pre_aggregation::*;
1010
use dimension_matcher::*;
1111
use measure_matcher::*;
1212
pub use optimizer::*;
13-
//pub use original_sql_collector::*;
13+
pub use original_sql_collector::*;
1414
//pub use original_sql_optimizer::*;
1515
pub use pre_aggregations_compiler::*;

rust/cubesqlplanner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/original_sql_collector.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@ impl OriginalSqlCollector {
1313
Self { query_tools }
1414
}
1515

16-
pub fn collect(&mut self, plan: &Query) -> Result<HashMap<String, String>, CubeError> {
17-
let mut cube_names_collector = CubeNamesCollector::new();
18-
cube_names_collector.collect(&plan)?;
19-
let cube_names = cube_names_collector.result();
16+
pub fn collect(&mut self, plan: &Rc<Query>) -> Result<HashMap<String, String>, CubeError> {
17+
let cube_names = collect_cube_names_from_node(&plan)?;
2018
let mut result = HashMap::new();
2119
for cube_name in cube_names.iter() {
2220
let pre_aggregations = self

rust/cubesqlplanner/cubesqlplanner/src/planner/base_query.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ use super::query_tools::QueryTools;
33
use super::QueryProperties;
44
use crate::cube_bridge::base_query_options::BaseQueryOptions;
55
use crate::cube_bridge::pre_aggregation_obj::NativePreAggregationObj;
6+
use crate::logical_plan::OriginalSqlCollector;
67
//use crate::logical_plan::optimizers::*;
78
use crate::logical_plan::PreAggregation;
89
use crate::logical_plan::PreAggregationOptimizer;
@@ -104,15 +105,15 @@ impl<IT: InnerTypes> BaseQuery<IT> {
104105

105106
let physical_plan_builder =
106107
PhysicalPlanBuilder::new(self.query_tools.clone(), templates.clone());
107-
/* let original_sql_pre_aggregations = if !self.request.is_pre_aggregation_query() {
108+
let original_sql_pre_aggregations = if !self.request.is_pre_aggregation_query() {
108109
OriginalSqlCollector::new(self.query_tools.clone()).collect(&optimized_plan)?
109110
} else {
110111
HashMap::new()
111-
}; */
112+
};
112113

113114
let physical_plan = physical_plan_builder.build(
114115
optimized_plan,
115-
HashMap::new(), //original_sql_pre_aggregations,
116+
original_sql_pre_aggregations,
116117
self.request.is_total_query(),
117118
)?;
118119

0 commit comments

Comments
 (0)