fix(databricks-jdbc-driver): Escape quotes in column names

mcheshkov · mcheshkov · commit 234230a703d1 · 2024-11-13T14:03:11.000+02:00
diff --git a/packages/cubejs-databricks-jdbc-driver/src/DatabricksQuery.ts b/packages/cubejs-databricks-jdbc-driver/src/DatabricksQuery.ts
@@ -141,7 +141,9 @@ export class DatabricksQuery extends BaseQuery {
   }
 
   public escapeColumnName(name: string) {
-    return `\`${name}\``;
+    // Use ` to escape ` itself.
+    // https://docs.databricks.com/en/sql/language-manual/sql-ref-identifiers.html
+    return `\`${name.replaceAll('`', '``')}\``;
   }
 
   public getFieldIndex(id: string) {

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,9 @@ export class DatabricksQuery extends BaseQuery {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`public escapeColumnName(name: string) {`
`144`		- return `\`${name}\``;
	`144`	+ // Use ` to escape ` itself.
	`145`	`+ // https://docs.databricks.com/en/sql/language-manual/sql-ref-identifiers.html`
	`146`	+ return `\`${name.replaceAll('`', '``')}\``;
`145`	`147`	`}`
`146`	`148`
`147`	`149`	`public getFieldIndex(id: string) {`