Skip to content

Commit 2790967

Browse files
committed
fix lint errors
1 parent 8dd1c8a commit 2790967

File tree

5 files changed

+12
-17
lines changed

5 files changed

+12
-17
lines changed

packages/cubejs-server-core/src/core/server.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ export class CubejsServerCore {
107107

108108
protected readonly orchestratorStorage: OrchestratorStorage = new OrchestratorStorage();
109109

110+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
110111
protected repositoryFactory: ((context: RequestContext) => SchemaFileRepository) | (() => FileRepository);
111112

112113
protected contextToDbType: DbTypeAsyncFn;
@@ -141,6 +142,7 @@ export class CubejsServerCore {
141142

142143
protected apiGatewayInstance: ApiGateway | null = null;
143144

145+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
144146
public readonly event: (name: string, props?: object) => Promise<void>;
145147

146148
public projectFingerprint: string | null = null;

packages/cubejs-testing-shared/src/db-container-runners/oracle.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { GenericContainer, Wait } from 'testcontainers';
2-
import { isCI } from '@cubejs-backend/shared';
32

43
import { DbRunnerAbstract, DBRunnerContainerOptions } from './db-runner.abstract';
54

packages/cubejs-testing-shared/src/db-container-runners/vertica.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import { GenericContainer } from 'testcontainers';
2-
import { DbRunnerAbstract } from './db-runner.abstract';
32
import { LogWaitStrategy } from 'testcontainers/build/wait-strategies/log-wait-strategy';
3+
import { DbRunnerAbstract } from './db-runner.abstract';
44

55
export class VerticaDBRunner extends DbRunnerAbstract {
66
public static startContainer() {
77
const version = process.env.TEST_VERTICA_VERSION || '11.1.1-0';
88

99
const container = new GenericContainer(`vertica/vertica-ce:${version}`)
10-
.withEnvironment({'TZ': 'Antarctica/Troll', 'VERTICA_DB_NAME': 'test'})
10+
.withEnvironment({ TZ: 'Antarctica/Troll', VERTICA_DB_NAME: 'test' })
1111
.withExposedPorts(5433)
1212
.withStartupTimeout(60 * 1000)
13-
.withWaitStrategy(new LogWaitStrategy("Node Status: v_test_node0001: (UP)", 1));
13+
.withWaitStrategy(new LogWaitStrategy('Node Status: v_test_node0001: (UP)', 1));
1414

1515
return container.start();
1616
}

packages/cubejs-testing/src/birdbox.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ export async function startBirdBoxFromContainer(
263263
if (pid !== null) {
264264
process.kill(pid, signal);
265265
} else {
266-
process.stdout.write(`[Birdbox] Cannot kill Cube instance running in TEST_CUBE_HOST mode without TEST_CUBE_PID defined\n`);
266+
process.stdout.write('[Birdbox] Cannot kill Cube instance running in TEST_CUBE_HOST mode without TEST_CUBE_PID defined\n');
267267
throw new Error('Attempted to use killCube while running with TEST_CUBE_HOST');
268268
}
269269
},

packages/cubejs-testing/test/smoke-oracle.test.ts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
1-
import { StartedTestContainer } from 'testcontainers';
2-
import { OracleDBRunner } from '@cubejs-backend/testing-shared';
3-
import cubejs, { CubeApi } from '@cubejs-client/core';
41
// eslint-disable-next-line import/no-extraneous-dependencies
5-
import { afterAll, beforeAll, expect, jest } from '@jest/globals';
6-
import { pausePromise } from '@cubejs-backend/shared';
7-
import { BirdBox, getBirdbox } from '../src';
8-
import { DEFAULT_API_TOKEN, DEFAULT_CONFIG, testQueryMeasure } from './smoke-tests';
2+
import { expect } from '@jest/globals';
93

104
// todo: @ovr fix me please
115
describe('oracle', () => {
12-
// jest.setTimeout(60 * 5 * 100000);
13-
// let db: StartedTestContainer;
14-
// let birdbox: BirdBox;
15-
// let client: CubejsApi;
6+
// jest.setTimeout(60 * 5 * 100000);
7+
// let db: StartedTestContainer;
8+
// let birdbox: BirdBox;
9+
// let client: CubejsApi;
1610

1711
// beforeAll(async () => {
1812
// db = await OracleDBRunner.startContainer({});
@@ -48,7 +42,7 @@ describe('oracle', () => {
4842
// });
4943

5044
// test('query measure', () => testQueryMeasure(client));
51-
45+
5246
test('query measure', () => {
5347
expect([{ 'Orders.totalAmount': 1700 }]).toMatchSnapshot('query');
5448
});

0 commit comments

Comments
 (0)