Skip to content

Commit 2c49b1d

Browse files
committed
fix(schema-compiler): fix undefined columns for pre lambda agg queries referencing dims from joined cubes
1 parent c127f36 commit 2c49b1d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,7 @@ export class PreAggregations {
961961
}
962962
);
963963
if (referencedPreAggregations.length === 0) {
964-
throw new UserError(`rollupLambda '${cube}.${preAggregationName}' should reference at least on rollup`);
964+
throw new UserError(`rollupLambda '${cube}.${preAggregationName}' should reference at least one rollup`);
965965
}
966966
referencedPreAggregations.forEach((referencedPreAggregation, i) => {
967967
if (i === referencedPreAggregations.length - 1 && preAggObj.preAggregation.unionWithSourceData && preAggObj.cube !== referencedPreAggregations[i].cube) {
@@ -1191,8 +1191,8 @@ export class PreAggregations {
11911191
const targetTimeDimensionsReferences = this.timeDimensionsRenderedReference(rollupGranularity, preAggregationForQuery);
11921192
const targetMeasuresReferences = this.measureAliasesRenderedReference(preAggregationForQuery);
11931193

1194-
const columnsFor = (targetReferences, references, preAggregation) => Object.keys(targetReferences).map(
1195-
member => `${references[this.query.cubeEvaluator.pathFromArray([preAggregation.cube, member.split('.')[1]])]} ${targetReferences[member]}`
1194+
const columnsFor = (targetReferences, references) => Object.keys(targetReferences).map(
1195+
member => `${references[member]} ${targetReferences[member]}`
11961196
);
11971197

11981198
const tables = preAggregationForQuery.referencedPreAggregations.map(preAggregation => {
@@ -1206,9 +1206,9 @@ export class PreAggregations {
12061206
preAggregation.preAggregationName,
12071207
preAggregation.preAggregation
12081208
),
1209-
columns: columnsFor(targetDimensionsReferences, dimensionsReferences, preAggregation)
1210-
.concat(columnsFor(targetTimeDimensionsReferences, timeDimensionsReferences, preAggregation))
1211-
.concat(columnsFor(targetMeasuresReferences, measuresReferences, preAggregation))
1209+
columns: columnsFor(targetDimensionsReferences, dimensionsReferences)
1210+
.concat(columnsFor(targetTimeDimensionsReferences, timeDimensionsReferences))
1211+
.concat(columnsFor(targetMeasuresReferences, measuresReferences))
12121212
};
12131213
});
12141214
if (tables.length === 1) {

0 commit comments

Comments
 (0)