Skip to content

Commit 315479c

Browse files
committed
add note
1 parent 275933b commit 315479c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

packages/cubejs-server-core/src/core/DevServer.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,12 @@ export class DevServer {
611611
app.post('/playground/schema/pre-aggregation', catchErrors(async (req: Request, res: Response) => {
612612
const { cubeName, preAggregationName, code } = req.body;
613613

614+
/**
615+
* Important note:
616+
* JS code for pre-agg includes the content of the pre-aggregation object
617+
* without name, which is passed as preAggregationName.
618+
* While yaml code for pre-agg includes whole yaml object including name.
619+
*/
614620
const schemaConverter = new CubeSchemaConverter(this.cubejsServer.repository, [
615621
new CubePreAggregationConverter({
616622
cubeName,

0 commit comments

Comments
 (0)