Skip to content

Commit 31d3953

Browse files
authored
Set LIMIT to 0 when filter is FALSE (#8332)
1 parent 8898fb1 commit 31d3953

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

rust/cubesql/cubesql/src/compile/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2842,7 +2842,7 @@ mod tests {
28422842
]),
28432843
time_dimensions: None,
28442844
order: None,
2845-
limit: Some(1),
2845+
limit: Some(0),
28462846
offset: None,
28472847
filters: None,
28482848
ungrouped: Some(true),
@@ -13268,7 +13268,7 @@ ORDER BY
1326813268
segments: Some(vec![]),
1326913269
time_dimensions: None,
1327013270
order: None,
13271-
limit: Some(1),
13271+
limit: Some(0),
1327213272
offset: None,
1327313273
filters: None,
1327413274
ungrouped: Some(true),

rust/cubesql/cubesql/src/compile/rewrite/rules/filters.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2522,7 +2522,7 @@ impl FilterRules {
25222522
if let ScalarValue::Boolean(Some(false)) = literal_value {
25232523
subst.insert(
25242524
new_limit_var,
2525-
egraph.add(LogicalPlanLanguage::CubeScanLimit(CubeScanLimit(Some(1)))),
2525+
egraph.add(LogicalPlanLanguage::CubeScanLimit(CubeScanLimit(Some(0)))),
25262526
);
25272527
subst.insert(
25282528
new_limit_skip_var,

0 commit comments

Comments
 (0)