fix(questdb-driver): Fix invalid QuestDB timestamp floor year unit (#9678)

* bugfix: Invalid QuestDB timestamp floor year unit

* feat: Unit GraphQL tests for year aggregation query

* fix tests

---------

Co-authored-by: Peter Klingelhofer <[email protected]>
Co-authored-by: Peter Klingelhofer <[email protected]>

Author: KSDaemon

packages/cubejs-api-gateway/test/__snapshots__/graphql.test.ts.snap

@@ -182,7 +182,9 @@ Object {
 `;
 
 exports[`GraphQL Schema with camelCase GraphQL query 6: query CubeQuery {
-  cube(where: { orders: { createdAt: { inDateRange: "2 weeks ago to now" } } }) {
+  cube(
+    where: { orders: { createdAt: { inDateRange: "2 weeks ago to now" } } }
+  ) {
     orders {
       count
       createdAt {
@@ -298,8 +300,7 @@ exports[`GraphQL Schema with camelCase GraphQL query 9: query CubeQuery {
       status
     }
   }
-}
- 1`] = `
+} 1`] = `
 Object {
   "dimensions": Array [
     "Orders.status",
@@ -339,6 +340,37 @@ Object {
 }
 `;
 
+exports[`GraphQL Schema with camelCase GraphQL query 10: query CubeQuery {
+  cube(where: { orders: { createdAt: { inDateRange: "This year" } } }) {
+    orders(orderBy: { createdAt: asc }) {
+      count
+      createdAt {
+        year
+      }
+    }
+  }
+}
+ 1`] = `
+Object {
+  "measures": Array [
+    "Orders.count",
+  ],
+  "order": Array [
+    Array [
+      "Orders.createdAt",
+      "asc",
+    ],
+  ],
+  "timeDimensions": Array [
+    Object {
+      "dateRange": "This year",
+      "dimension": "Orders.createdAt",
+      "granularity": "year",
+    },
+  ],
+}
+`;
+
 exports[`GraphQL Schema with snake_case GraphQL query 0: query CubeQuery {
   cube {
     orders {
@@ -521,7 +553,9 @@ Object {
 `;
 
 exports[`GraphQL Schema with snake_case GraphQL query 6: query CubeQuery {
-  cube(where: { orders: { created_at: { inDateRange: "2 weeks ago to now" } } }) {
+  cube(
+    where: { orders: { created_at: { inDateRange: "2 weeks ago to now" } } }
+  ) {
     orders {
       count
       created_at {
@@ -637,8 +671,7 @@ exports[`GraphQL Schema with snake_case GraphQL query 9: query CubeQuery {
       status
     }
   }
-}
- 1`] = `
+} 1`] = `
 Object {
   "dimensions": Array [
     "orders.status",
@@ -677,3 +710,34 @@ Object {
   ],
 }
 `;
+
+exports[`GraphQL Schema with snake_case GraphQL query 10: query CubeQuery {
+  cube(where: { orders: { created_at: { inDateRange: "This year" } } }) {
+    orders(orderBy: { created_at: asc }) {
+      count
+      created_at {
+        year
+      }
+    }
+  }
+}
+ 1`] = `
+Object {
+  "measures": Array [
+    "orders.count",
+  ],
+  "order": Array [
+    Array [
+      "orders.created_at",
+      "asc",
+    ],
+  ],
+  "timeDimensions": Array [
+    Object {
+      "dateRange": "This year",
+      "dimension": "orders.created_at",
+      "granularity": "year",
+    },
+  ],
+}
+`;

packages/cubejs-api-gateway/test/graphql-queries/base-snake-case.gql

@@ -73,7 +73,9 @@ query CubeQuery {
 }
 
 query CubeQuery {
-  cube(where: { orders: { created_at: { inDateRange: "2 weeks ago to now" } } }) {
+  cube(
+    where: { orders: { created_at: { inDateRange: "2 weeks ago to now" } } }
+  ) {
     orders {
       count
       created_at {
@@ -130,3 +132,14 @@ query CubeQuery {
     }
   }
 }
+
+query CubeQuery {
+  cube(where: { orders: { created_at: { inDateRange: "This year" } } }) {
+    orders(orderBy: { created_at: asc }) {
+      count
+      created_at {
+        year
+      }
+    }
+  }
+}

packages/cubejs-api-gateway/test/graphql-queries/base.gql

@@ -73,7 +73,9 @@ query CubeQuery {
 }
 
 query CubeQuery {
-  cube(where: { orders: { createdAt: { inDateRange: "2 weeks ago to now" } } }) {
+  cube(
+    where: { orders: { createdAt: { inDateRange: "2 weeks ago to now" } } }
+  ) {
     orders {
       count
       createdAt {
@@ -130,3 +132,14 @@ query CubeQuery {
     }
   }
 }
+
+query CubeQuery {
+  cube(where: { orders: { createdAt: { inDateRange: "This year" } } }) {
+    orders(orderBy: { createdAt: asc }) {
+      count
+      createdAt {
+        year
+      }
+    }
+  }
+}

packages/cubejs-questdb-driver/src/QuestQuery.ts

@@ -6,7 +6,7 @@ const GRANULARITY_TO_INTERVAL: Record<string, string> = {
   hour: 'h',
   day: 'd',
   month: 'M',
-  year: 'Y'
+  year: 'y'
 };
 
 class QuestParamAllocator extends ParamAllocator {

packages/cubejs-questdb-driver/test/QuestDriver.test.ts

@@ -62,7 +62,7 @@ describe('QuestDriver', () => {
       throw new Error('stream must throw an exception');
     } catch (e) {
       expect((e as Error).message).toEqual(
-        'table does not exist [name=random_name_for_table_that_doesnot_exist_sql_must_fail]'
+        'table does not exist [table=random_name_for_table_that_doesnot_exist_sql_must_fail]'
       );
     }
   });
@@ -71,56 +71,20 @@ describe('QuestDriver', () => {
     const schema = await driver.tablesSchema();
 
     expect(schema['']).toEqual({
-        'query_test': [
-          {
-            name: 'id',
-            type: 'LONG',
-          },
-          {
-            name: 'created',
-            type: 'date',
-          },
-          {
-            name: 'price',
-            type: 'DOUBLE',
-          },
-        ],
-        'telemetry': [
-          {
-            name: 'created',
-            type: 'TIMESTAMP',
-          },
-          {
-            name: 'event',
-            type: 'SHORT',
-          },
-          {
-            name: 'origin',
-            type: 'SHORT',
-          },
-        ],
-        'telemetry_config': [
-          {
-            name: 'id',
-            type: 'LONG256',
-          },
-          {
-            name: 'enabled',
-            type: 'boolean',
-          },
-          {
-            name: 'version',
-            type: 'SYMBOL',
-          },
-          {
-            name: 'os',
-            type: 'SYMBOL',
-          },
-          {
-            name: 'package',
-            type: 'SYMBOL',
-          },
-        ],
+      query_test: [
+        {
+          name: 'id',
+          type: 'LONG',
+        },
+        {
+          name: 'created',
+          type: 'date',
+        },
+        {
+          name: 'price',
+          type: 'DOUBLE',
+        },
+      ],
     });
   });
 });