Skip to content

Commit 34d0093

Browse files
committed
change order of the references lookup
1 parent a513da3 commit 34d0093

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,20 +1193,21 @@ export class PreAggregations {
11931193

11941194
const columnsFor = (targetReferences, references, preAggregation) => Object.keys(targetReferences).map(
11951195
member => {
1196-
const [memberCube, memberProp] = member.split('.');
1197-
let refKey = references[this.query.cubeEvaluator.pathFromArray([preAggregation.cube, memberProp])];
1196+
const [, memberProp] = member.split('.');
1197+
1198+
let refKey = references[member];
11981199

11991200
if (refKey) {
12001201
return `${refKey} ${targetReferences[member]}`;
12011202
}
12021203

1203-
// Preaggregation may reference the joined cube dimensions/measures
1204-
if (this.query.cubeEvaluator.cubeFromPath(preAggregation.cube).joins[memberCube]) {
1205-
refKey = references[this.query.cubeEvaluator.pathFromArray([memberCube, memberProp])];
1204+
refKey = references[this.query.cubeEvaluator.pathFromArray([preAggregation.cube, memberProp])];
1205+
1206+
if (refKey) {
12061207
return `${refKey} ${targetReferences[member]}`;
12071208
}
12081209

1209-
throw new Error(`Preaggregation "${preAggregation.preAggregationName}" referenced property "${memberCube}.${memberProp}" not found in cube "${preAggregation.cube}"`);
1210+
throw new Error(`Preaggregation "${preAggregation.preAggregationName}" referenced property "${member}" not found in cube "${preAggregation.cube}"`);
12101211
}
12111212
);
12121213

0 commit comments

Comments
 (0)