Skip to content

Commit 358c2b6

Browse files
committed
fix version, names, refs to align with the Cube repo
1 parent 85d56a0 commit 358c2b6

File tree

6 files changed

+15
-39
lines changed

6 files changed

+15
-39
lines changed

.github/workflows/drivers-tests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ on:
5151
- 'packages/cubejs-postgres-driver/**'
5252
- 'packages/cubejs-snowflake-driver/**'
5353
- 'packages/cubejs-vertica-driver/**'
54-
54+
5555
# To test SQL API Push down
5656
- 'packages/cubejs-backend-native/**'
5757
- 'rust/cubesql/**'
@@ -205,7 +205,6 @@ jobs:
205205
snowflake-export-bucket-azure
206206
snowflake-export-bucket-azure-via-storage-integration
207207
snowflake-export-bucket-gcs
208-
vertica
209208
# As per docs:
210209
# Secrets cannot be directly referenced in if: conditionals. Instead, consider setting
211210
# secrets as job-level environment variables, then referencing the environment variables

packages/cubejs-docker/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
"@cubejs-backend/snowflake-driver": "1.1.10",
3737
"@cubejs-backend/sqlite-driver": "1.1.10",
3838
"@cubejs-backend/trino-driver": "1.1.11",
39+
"@cubejs-backend/vertica-driver": "1.1.11",
3940
"cubejs-cli": "1.1.11",
40-
"@knowitall/vertica-driver": "^0.32.4",
4141
"typescript": "~5.2.2"
4242
},
4343
"resolutions": {

packages/cubejs-server-core/src/core/DriverDependencies.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module.exports = {
2626
ksql: '@cubejs-backend/ksql-driver',
2727
questdb: '@cubejs-backend/questdb-driver',
2828
materialize: '@cubejs-backend/materialize-driver',
29-
vertica: '@knowitall/vertica-driver',
29+
vertica: '@cubejs-backend/vertica-driver',
3030
pinot: '@cubejs-backend/pinot-driver',
3131
// List for JDBC drivers
3232
'databricks-jdbc': '@cubejs-backend/databricks-jdbc-driver',

packages/cubejs-testing/birdbox-fixtures/vertica.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ services:
1111
CUBEJS_DB_PORT: 5433
1212
CUBEJS_DB_NAME: vmart
1313
CUBEJS_DB_USER: dbadmin
14-
CUBEJS_DB_PASS:
14+
CUBEJS_DB_PASS:
1515

1616
CUBEJS_DEV_MODE: "true"
1717
CUBEJS_WEB_SOCKETS: "true"
@@ -33,7 +33,7 @@ services:
3333

3434
db:
3535
container_name: birdbox-db
36-
image: vertica/vertica-ce:11.1.1-0
36+
image: vertica/vertica-ce:12.0.4-0
3737
ports:
3838
- "5433"
3939
restart: always

packages/cubejs-vertica-driver/README.md

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,38 +11,14 @@ Cube.js Vertica driver that uses [vertica-nodejs](https://github.com/vertica/ver
1111

1212
[Learn more](https://github.com/cube-js/cube.js#getting-started)
1313

14-
### Project Status
15-
16-
Project is WIP pending approval of [PR 7298](https://github.com/cube-js/cube/pull/7289).
17-
18-
A recent build of cubejs with the vertica driver preinstalled is available as a public docker image while the project is WIP
19-
20-
`docker pull timbrownls26/cubejs-vertica:0.0.1`
21-
22-
### Installation
23-
24-
`npm i @knowitall/vertica-driver`
25-
26-
### Usage
27-
#### For Docker
28-
29-
Build development [docker image](https://github.com/cube-js/cube/blob/master/packages/cubejs-docker/DEVELOPMENT.md) from variant of cubejs in this [PR 7298](https://github.com/cube-js/cube/pull/7289).
30-
31-
Assuming the built image is tagged `cubejs/cube:dev`
32-
33-
```
34-
FROM cubejs/cube:dev
35-
36-
RUN npm i @knowitall/vertica-driver
37-
```
38-
39-
Note: This driver isn't supported by front-end so we can not use connection wizard to config vertica data source. Please use env instead.
14+
Note: This driver isn't supported by front-end so we can not use connection wizard to config vertica data source. Please
15+
use env instead.
4016

4117
```
4218
environment:
4319
- CUBEJS_DB_TYPE=vertica
4420
- CUBEJS_DB_HOST= #host
45-
- CUBEJS_DB_NAME= #database name
21+
- CUBEJS_DB_NAME= #database name
4622
- CUBEJS_DB_PORT=5433
4723
- CUBEJS_DB_USER= #database user
4824
- CUBEJS_DB_PASS= #database password

packages/cubejs-vertica-driver/package.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
22
"name": "@cubejs-backend/vertica-driver",
33
"description": "Cube.js Vertica database driver",
4-
"author": "Cube Dev, Inc.",
5-
"version": "1.1.9",
4+
"author": "Eduard Karacharov, Tim Brown, Cube Dev, Inc.",
5+
"version": "1.1.11",
66
"repository": {
77
"type": "git",
88
"url": "https://github.com/cube-js/cube.js.git",
99
"directory": "packages/cubejs-vertica-driver"
1010
},
1111
"engines": {
12-
"node": "^12.0.0 || ^14.0.0 || >=16.0.0"
12+
"node": "^14.0.0 || ^16.0.0 || >=17.0.0"
1313
},
1414
"main": "src/VerticaDriver.js",
1515
"scripts": {
@@ -19,15 +19,16 @@
1919
"lint:fix": "eslint --fix **/*.js"
2020
},
2121
"dependencies": {
22-
"@cubejs-backend/query-orchestrator": "1.1.8",
23-
"@cubejs-backend/schema-compiler": "1.1.8",
22+
"@cubejs-backend/base-driver": "1.1.10",
23+
"@cubejs-backend/query-orchestrator": "1.1.10",
24+
"@cubejs-backend/schema-compiler": "1.1.11",
2425
"moment-timezone": "^0.5.45",
2526
"vertica-nodejs": "^1.0.3"
2627
},
2728
"license": "Apache-2.0",
2829
"devDependencies": {
2930
"@cubejs-backend/linter": "^1.0.0",
30-
"@knowitall/testing-shared": "1.1.8",
31+
"@cubejs-backend/testing-shared": "1.1.11",
3132
"jest": "^27.5.1",
3233
"testcontainers": "^10.13.0"
3334
},

0 commit comments

Comments
 (0)