Skip to content

Commit 3889a4e

Browse files
committed
add a comment
1 parent 9131d79 commit 3889a4e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/cubejs-schema-compiler/src/adapter/PreAggregations.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,8 @@ export class PreAggregations {
112112

113113
return R.pipe(
114114
R.unnest as (list: any[][]) => any[],
115+
// TODO: Move this to somewhere BEFORE pre-agg matching, possibly to rollupMatchResults()
116+
// to avoid constly matching and then throwing it away.
115117
R.filter((agg: FullPreAggregationDescription) => !(disableExternalPreAggregations && agg.external)),
116118
R.uniqBy(desc => desc.tableName)
117119
)(preAggregations);

0 commit comments

Comments
 (0)