Skip to content

Commit 3c61467

Browse files
authored
Revert "feat(api-gateway, server-core): Added dataSources list to extended meta (#5743)" (#5785)
This reverts commit 2c5db32.
1 parent f1140de commit 3c61467

File tree

3 files changed

+3
-59
lines changed

3 files changed

+3
-59
lines changed

packages/cubejs-api-gateway/src/gateway.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ class ApiGateway {
448448
const metaConfigExtended = await this.getCompilerApi(context).metaConfigExtended({
449449
requestId: context.requestId,
450450
});
451-
const { metaConfig, cubeDefinitions, dataSources } = metaConfigExtended;
451+
const { metaConfig, cubeDefinitions } = metaConfigExtended;
452452

453453
const cubes = this.filterVisibleItemsInMeta(context, metaConfig)
454454
.map((meta) => meta.config)
@@ -466,7 +466,7 @@ class ApiGateway {
466466
joins: transformJoins(cubeDefinitions[cube.name]?.joins),
467467
preAggregations: transformPreAggregations(cubeDefinitions[cube.name]?.preAggregations),
468468
}));
469-
res({ cubes, dataSources });
469+
res({ cubes });
470470
} catch (e) {
471471
this.handleError({
472472
e,

packages/cubejs-server-core/src/core/CompilerApi.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@ export class CompilerApi {
6666
return this.compilers;
6767
}
6868

69-
async getDataSources(cubeEvaluator) {
70-
return Promise.all(cubeEvaluator.cubeNames().map(async cube => cubeEvaluator.cubeFromPath(cube).dataSource ?? 'default'));
71-
}
72-
7369
async createQueryFactory(compilers) {
7470
const { cubeEvaluator } = compilers;
7571

@@ -184,10 +180,9 @@ export class CompilerApi {
184180
}
185181

186182
async metaConfigExtended(options) {
187-
const { metaTransformer, cubeEvaluator } = await this.getCompilers(options);
183+
const { metaTransformer } = await this.getCompilers(options);
188184
return {
189185
metaConfig: metaTransformer?.cubes,
190-
dataSources: await this.getDataSources(cubeEvaluator),
191186
cubeDefinitions: metaTransformer?.cubeEvaluator?.cubeDefinitions,
192187
};
193188
}

packages/cubejs-server-core/test/unit/index.test.ts

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -52,34 +52,6 @@ cube('Bar', {
5252
]),
5353
};
5454

55-
const repositoryWithDataSource: SchemaFileRepository = {
56-
localPath: () => __dirname,
57-
dataSchemaFiles: () => Promise.resolve([
58-
{
59-
fileName: 'main.js', content: `
60-
cube('Bar', {
61-
sql: 'select * from bar',
62-
63-
measures: {
64-
count: {
65-
type: 'count'
66-
}
67-
},
68-
69-
dataSource: 'dataSource',
70-
71-
dimensions: {
72-
time: {
73-
sql: 'timestamp',
74-
type: 'time'
75-
}
76-
}
77-
});
78-
`,
79-
},
80-
]),
81-
};
82-
8355
const repositoryWithoutContent: SchemaFileRepository = {
8456
localPath: () => __dirname,
8557
dataSchemaFiles: () => Promise.resolve([{ fileName: 'main.js', content: '' }]),
@@ -363,29 +335,6 @@ describe('index.test', () => {
363335
expect(metaConfigExtended).toHaveProperty('metaConfig');
364336
expect(metaConfigExtended.metaConfig.length).toBeGreaterThan(0);
365337
expect(metaConfigExtended).toHaveProperty('cubeDefinitions');
366-
expect(metaConfigExtended).toHaveProperty('dataSources');
367-
expect(metaConfigExtended.dataSources).toEqual(['default']);
368-
expect(metaConfigExtendedSpy).toHaveBeenCalled();
369-
metaConfigExtendedSpy.mockClear();
370-
});
371-
});
372-
373-
describe('CompilerApi with dataSource', () => {
374-
const logger = jest.fn(() => {});
375-
const compilerApi = new CompilerApi(
376-
repositoryWithDataSource,
377-
async () => 'mysql',
378-
{ logger }
379-
);
380-
const metaConfigExtendedSpy = jest.spyOn(compilerApi, 'metaConfigExtended');
381-
382-
test('CompilerApi metaConfigExtended', async () => {
383-
const metaConfigExtended = await compilerApi.metaConfigExtended({ requestId: 'XXX' });
384-
expect(metaConfigExtended).toHaveProperty('metaConfig');
385-
expect(metaConfigExtended.metaConfig.length).toBeGreaterThan(0);
386-
expect(metaConfigExtended).toHaveProperty('cubeDefinitions');
387-
expect(metaConfigExtended).toHaveProperty('dataSources');
388-
expect(metaConfigExtended.dataSources).toEqual(['dataSource']);
389338
expect(metaConfigExtendedSpy).toHaveBeenCalled();
390339
metaConfigExtendedSpy.mockClear();
391340
});

0 commit comments

Comments
 (0)