[FIXUP proper message] more tests

Author: mcheshkov

rust/cubesql/cubesql/src/compile/test/test_wrapper.rs

@@ -1093,11 +1093,66 @@ async fn wrapper_agg_over_limit() {
         .unwrap()
         .sql
         .contains("\"limit\":5"));
-    assert!(!query_plan
-        .as_logical_plan()
+    assert!(logical_plan
+        .find_cube_scan_wrapper()
+        .wrapped_sql
+        .unwrap()
+        .sql
+        .contains("\"ungrouped\":true"));
+}
+
+/// Aggregation(dimension) with falsy filter should NOT get pushed to CubeScan with limit=0
+#[tokio::test]
+async fn wrapper_dimension_agg_where_false() {
+    if !Rewriter::sql_push_down_enabled() {
+        return;
+    }
+    init_testing_logger();
+
+    let query_plan = convert_select_to_query_plan(
+        // language=PostgreSQL
+        r#"
+        SELECT
+            MAX(customer_gender)
+        FROM
+            KibanaSampleDataEcommerce
+        WHERE 1 = 0
+        "#
+        .to_string(),
+        DatabaseProtocol::PostgreSQL,
+    )
+    .await;
+
+    let physical_plan = query_plan.as_physical_plan().await.unwrap();
+    println!(
+        "Physical plan: {}",
+        displayable(physical_plan.as_ref()).indent()
+    );
+
+    let logical_plan = query_plan.as_logical_plan();
+    assert_eq!(
+        logical_plan.find_cube_scan().request,
+        V1LoadRequestQuery {
+            measures: Some(vec![]),
+            dimensions: Some(vec![]),
+            segments: Some(vec![]),
+            order: Some(vec![]),
+            limit: Some(0),
+            ungrouped: Some(true),
+            ..Default::default()
+        }
+    );
+
+    assert!(logical_plan
+        .find_cube_scan_wrapper()
+        .wrapped_sql
+        .unwrap()
+        .sql
+        .contains("\"limit\":0"));
+    assert!(logical_plan
         .find_cube_scan_wrapper()
         .wrapped_sql
         .unwrap()
         .sql
-        .contains("ungrouped"));
+        .contains("\"ungrouped\":true"));
 }