update native error reporter to use RefCells instead of Arc Mutex

Author: KSDaemon

rust/cubetranspilers/src/error_reporter.rs

@@ -1,23 +1,23 @@
-use std::sync::{Arc, Mutex};
+use std::cell::RefCell;
 
 use swc_core::common::errors::{DiagnosticBuilder, Emitter};
 
 pub struct ErrorReporter {
-    pub errors: Arc<Mutex<Vec<String>>>,
-    pub warnings: Arc<Mutex<Vec<String>>>,
+    pub errors: RefCell<Vec<String>>,
+    pub warnings: RefCell<Vec<String>>,
 }
 
 impl ErrorReporter {
-    pub fn new(errors: Arc<Mutex<Vec<String>>>, warnings: Arc<Mutex<Vec<String>>>) -> Self {
+    pub fn new(errors: RefCell<Vec<String>>, warnings: RefCell<Vec<String>>) -> Self {
         ErrorReporter { errors, warnings }
     }
 }
 
 impl Default for ErrorReporter {
     fn default() -> Self {
         ErrorReporter {
-            errors: Arc::new(Mutex::new(Vec::new())),
-            warnings: Arc::new(Mutex::new(Vec::new())),
+            errors: RefCell::new(Vec::new()),
+            warnings: RefCell::new(Vec::new()),
         }
     }
 }
@@ -29,16 +29,14 @@ impl Emitter for ErrorReporter {
             | swc_core::common::errors::Level::Fatal
             | swc_core::common::errors::Level::PhaseFatal
             | swc_core::common::errors::Level::Error => {
-                let mut errors = self.errors.lock().unwrap();
-                errors.push(diagnostic.message());
+                self.errors.borrow_mut().push(diagnostic.message());
             }
             swc_core::common::errors::Level::Warning
             | swc_core::common::errors::Level::Note
             | swc_core::common::errors::Level::Help
             | swc_core::common::errors::Level::Cancelled
             | swc_core::common::errors::Level::FailureNote => {
-                let mut warnings = self.warnings.lock().unwrap();
-                warnings.push(diagnostic.message());
+                self.warnings.borrow_mut().push(diagnostic.message());
             }
         }
     }

rust/cubetranspilers/src/lib.rs

@@ -5,8 +5,8 @@ use crate::validation_transpiler::ValidationTransformVisitor;
 use anyhow::{anyhow, Result};
 use error_reporter::ErrorReporter;
 use serde::{Deserialize, Serialize};
+use std::cell::RefCell;
 use std::collections::{HashMap, HashSet};
-use std::sync::{Arc, Mutex};
 use swc_core::common::errors::{Handler, HandlerFlags};
 use swc_core::common::input::StringInput;
 use swc_core::common::sync::{Lrc, OnceCell};
@@ -57,7 +57,7 @@ pub fn run_transpilers(
 ) -> Result<TransformResult> {
     let sm: Lrc<SourceMap> = Default::default();
     let sf = sm.new_source_file(
-        Arc::new(FileName::Custom(transform_config.file_name)),
+        Lrc::new(FileName::Custom(transform_config.file_name)),
         sources,
     );
 
@@ -83,8 +83,8 @@ pub fn run_transpilers(
         source_file: sm_cell,
     };
 
-    let errors = Arc::new(Mutex::new(Vec::new()));
-    let warnings = Arc::new(Mutex::new(Vec::new()));
+    let errors = RefCell::new(Vec::new());
+    let warnings = RefCell::new(Vec::new());
 
     let reporter = Box::new(ErrorReporter::new(errors.clone(), warnings.clone()));
     let handler = Handler::with_emitter_and_flags(
@@ -127,8 +127,8 @@ pub fn run_transpilers(
         });
 
     let output_code = generate_code(&program, &sm)?;
-    let errors = errors.lock().unwrap().clone();
-    let warnings = warnings.lock().unwrap().clone();
+    let errors = errors.borrow().clone();
+    let warnings = warnings.borrow().clone();
 
     Ok(TransformResult {
         code: output_code,