Skip to content

Commit 42861a4

Browse files
authored
test(schema-compiler): Fix question mark tests (#8941)
sqlstring uses different question mark sequences for different placehloders: ? for value, ?? for identifier, and skips replacing for ???
1 parent c127f36 commit 42861a4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/cubejs-schema-compiler/test/integration/mssql/mssql-ungrouped.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ describe('MSSqlUngrouped', () => {
173173
longitude: { sql: \`longitude\` }
174174
},
175175
questionMark: {
176-
sql: \`replace('some string question string???', 'string', 'with some ???')\`,
176+
sql: \`replace('some string question string ? ?? ???', 'string', 'with some ? ?? ???')\`,
177177
type: \`string\`
178178
}
179179
}

packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ describe('SQL Generation', () => {
277277
longitude: { sql: \`longitude\` }
278278
},
279279
questionMark: {
280-
sql: \`replace('some string question string???', 'string', 'with some ???')\`,
280+
sql: \`replace('some string question string ? ?? ???', 'string', 'with some ? ?? ???')\`,
281281
type: \`string\`
282282
}
283283
}

0 commit comments

Comments
 (0)