Skip to content

Commit 4e243c2

Browse files
committed
chore: Remove the length check for pre-aggregation table name (including schema) as redundant since external pre-aggregations in Cube Store don't need a low length limit
1 parent 04deee9 commit 4e243c2

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

packages/cubejs-schema-compiler/src/adapter/MysqlQuery.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,6 @@ export class MysqlQuery extends BaseQuery {
146146
return `IF(${sql}, 1, 0)`;
147147
}
148148

149-
public preAggregationTableName(cube, preAggregationName, skipSchema) {
150-
const name = super.preAggregationTableName(cube, preAggregationName, skipSchema);
151-
if (name.length > 64) {
152-
throw new UserError(`MySQL can not work with table names that longer than 64 symbols. Consider using the 'sqlAlias' attribute in your cube and in your pre-aggregation definition for ${name}.`);
153-
}
154-
return name;
155-
}
156-
157149
public sqlTemplates() {
158150
const templates = super.sqlTemplates();
159151
templates.quotes.identifiers = '`';

packages/cubejs-schema-compiler/src/adapter/OracleQuery.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,4 @@ export class OracleQuery extends BaseQuery {
9797
// eslint-disable-next-line quotes
9898
return `((cast (systimestamp at time zone 'UTC' as date) - date '1970-01-01') * 86400)`;
9999
}
100-
101-
public preAggregationTableName(cube, preAggregationName, skipSchema) {
102-
const name = super.preAggregationTableName(cube, preAggregationName, skipSchema);
103-
if (name.length > 128) {
104-
throw new UserError(`Oracle can not work with table names that longer than 64 symbols. Consider using the 'sqlAlias' attribute in your cube and in your pre-aggregation definition for ${name}.`);
105-
}
106-
return name;
107-
}
108100
}

0 commit comments

Comments
 (0)