fix: Simplify external refresh condition so when pre-aggregation buil… (#10116)

paveltiunov · web-flow · commit 4f4a0b4bbab2 · 2025-11-05T14:17:58.000-08:00
* fix: Simplify external refresh condition so when pre-aggregation builder is set so it's never an external refresh instance

* Fix tests should be in production mode
diff --git a/packages/cubejs-server-core/src/core/OptsHandler.ts b/packages/cubejs-server-core/src/core/OptsHandler.ts
@@ -686,10 +686,7 @@ export class OptsHandler {
     clone.preAggregationsOptions.externalRefresh =
       clone.preAggregationsOptions.externalRefresh !== undefined
         ? clone.preAggregationsOptions.externalRefresh
-        : (
-          !this.isPreAggsBuilder() ||
-          clone.rollupOnlyMode && !this.configuredForScheduledRefresh()
-        );
+        : !this.isPreAggsBuilder();
 
     clone.preAggregationsOptions.maxPartitions =
       clone.preAggregationsOptions.maxPartitions !== undefined
diff --git a/packages/cubejs-server-core/test/unit/index.test.ts b/packages/cubejs-server-core/test/unit/index.test.ts
@@ -665,6 +665,8 @@ describe('index.test', () => {
     });
 
     test(testName || `scheduledRefreshTimer option setRefreshWorker: ${paramsToName})}`, async () => {
+      process.env.NODE_ENV = 'production';
+
       if (setRefreshWorker !== undefined) {
         process.env.CUBEJS_REFRESH_WORKER = setRefreshWorker.toString();
       }

Original file line number	Diff line number	Diff line change
`@@ -665,6 +665,8 @@ describe('index.test', () => {`
`665`	`665`	`});`
`666`	`666`
`667`	`667`	test(testName \|\| `scheduledRefreshTimer option setRefreshWorker: ${paramsToName})}`, async () => {
	`668`	`+ process.env.NODE_ENV = 'production';`
	`669`	`+`
`668`	`670`	`if (setRefreshWorker !== undefined) {`
`669`	`671`	`process.env.CUBEJS_REFRESH_WORKER = setRefreshWorker.toString();`
`670`	`672`	`}`