Skip to content

Commit 5125ff7

Browse files
committed
improve
1 parent 0e6adb0 commit 5125ff7

File tree

1 file changed

+6
-8
lines changed
  • rust/cubesql/cubesql/src/compile/rewrite/rules

1 file changed

+6
-8
lines changed

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use crate::{
22
compile::rewrite::{
33
agg_fun_expr, aggregate, alias_expr, all_members,
4-
analysis::{ConstantFolding, LogicalPlanData, MemberNamesToExpr, OriginalExpr},
4+
analysis::{ConstantFolding, LogicalPlanData, Member, MemberNamesToExpr, OriginalExpr},
55
binary_expr, cast_expr, change_user_expr, column_expr, cross_join, cube_scan,
66
cube_scan_filters_empty_tail, cube_scan_members, cube_scan_members_empty_tail,
77
cube_scan_order_empty_tail, dimension_expr, distinct, expr_column_name, fun_expr, join,
@@ -1548,13 +1548,11 @@ impl MemberRules {
15481548
names_to_expr.list.iter().all(|(_, member, _)| {
15491549
// we should allow transform for queries with dimensions only,
15501550
// as it doesn't make sense for measures
1551-
if let Some(name) = member.name() {
1552-
meta_context
1553-
.find_dimension_with_name(name.to_string())
1554-
.is_some()
1555-
|| meta_context.is_synthetic_field(name.to_string())
1556-
} else {
1557-
true
1551+
match member {
1552+
Member::Dimension { .. } => true,
1553+
Member::VirtualField { .. } => true,
1554+
Member::LiteralMember { .. } => true,
1555+
_ => false,
15581556
}
15591557
})
15601558
}

0 commit comments

Comments
 (0)