Skip to content

Commit 5126d00

Browse files
authored
fix(cubestore): Setup format_version = 5 (previusly used with RocksDB 6.20.3) (#6283)
1 parent 6b48c65 commit 5126d00

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

rust/cubestore/cubestore/src/cachestore/cache_rocksstore.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,7 @@ impl RocksStoreDetails for RocksCacheStoreDetails {
8383

8484
let mut block_opts = BlockBasedOptions::default();
8585
// https://github.com/facebook/rocksdb/blob/v7.9.2/include/rocksdb/table.h#L524
86-
// RocksDB 7.x uses a new format = 5, but our previous version if RocksDB has some issues with it
87-
// Let force the usage of old format for 1 month to save an ability to revert releases
88-
// todo(ovr): Migrate to 5
89-
block_opts.set_format_version(2);
86+
block_opts.set_format_version(5);
9087

9188
opts.set_block_based_table_factory(&block_opts);
9289

rust/cubestore/cubestore/src/metastore/mod.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,10 +1153,7 @@ impl RocksStoreDetails for RocksMetaStoreDetails {
11531153

11541154
let mut block_opts = BlockBasedOptions::default();
11551155
// https://github.com/facebook/rocksdb/blob/v7.9.2/include/rocksdb/table.h#L524
1156-
// RocksDB 7.x uses a new format = 5, but our previous version if RocksDB has some issues with it
1157-
// Let force the usage of old format for 1 month to save an ability to revert releases
1158-
// todo(ovr): Migrate to 5
1159-
block_opts.set_format_version(2);
1156+
block_opts.set_format_version(5);
11601157

11611158
opts.set_block_based_table_factory(&block_opts);
11621159

0 commit comments

Comments
 (0)