Skip to content

Commit 52da601

Browse files
authored
feat(mssql-driver): Return numeric result values as strings (#9485)
* code hygiene * upgrade mssql pkg * Switch to ts * workaround for mssql types missed types * add value transformators * update snapshots * Some updates to health check * sync lock * upd package.json * fix package.json * fix lint errors
1 parent 41d0f56 commit 52da601

File tree

17 files changed

+1142
-1014
lines changed

17 files changed

+1142
-1014
lines changed

packages/cubejs-base-driver/src/BaseDriver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ export abstract class BaseDriver implements DriverInterface {
408408
};
409409
}
410410

411-
public readOnly() {
411+
public readOnly(): boolean {
412412
return false;
413413
}
414414

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
dist

packages/cubejs-mssql-driver/driver/QueryStream.js

Lines changed: 0 additions & 62 deletions
This file was deleted.

packages/cubejs-mssql-driver/driver/index.d.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
const fromExports = require('./dist/src');
2+
const { MSSqlDriver } = require('./dist/src/MSSqlDriver');
3+
4+
const toExport = MSSqlDriver;
5+
6+
// eslint-disable-next-line no-restricted-syntax
7+
for (const [key, module] of Object.entries(fromExports)) {
8+
toExport[key] = module;
9+
}
10+
11+
module.exports = toExport;

packages/cubejs-mssql-driver/package.json

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,34 @@
1111
"engines": {
1212
"node": "^14.0.0 || ^16.0.0 || >=17.0.0"
1313
},
14-
"main": "driver/MSSqlDriver.js",
14+
"files": [
15+
"dist/src",
16+
"index.js"
17+
],
18+
"main": "index.js",
19+
"typings": "dist/src/index.d.ts",
20+
"scripts": {
21+
"build": "rm -rf dist && npm run tsc",
22+
"tsc": "tsc",
23+
"watch": "tsc -w",
24+
"lint": "eslint src/* --ext .ts,.js",
25+
"lint:fix": "eslint --fix src/* --ext .ts,.js"
26+
},
1527
"dependencies": {
1628
"@cubejs-backend/base-driver": "1.3.5",
17-
"mssql": "^10.0.2"
29+
"@cubejs-backend/shared": "1.3.5",
30+
"mssql": "^11.0.1"
1831
},
1932
"devDependencies": {
20-
"@types/mssql": "^9.1.5",
33+
"@types/mssql": "^9.1.7",
2134
"@types/node": "^20"
2235
},
2336
"jest": {
2437
"testEnvironment": "node"
2538
},
39+
"eslintConfig": {
40+
"extends": "../cubejs-linter"
41+
},
2642
"license": "Apache-2.0",
2743
"publishConfig": {
2844
"access": "public"

0 commit comments

Comments
 (0)