Skip to content

Commit 542859a

Browse files
committed
100 tests
1 parent e9368bd commit 542859a

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

rust/cubesqlplanner/cubesqlplanner/src/planner/base_member.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,7 @@ impl BaseMemberHelper {
5454
member_suffix: &Option<String>,
5555
query_tools: Rc<QueryTools>,
5656
) -> Result<String, CubeError> {
57-
let cube_definition = query_tools
58-
.cube_evaluator()
59-
.cube_from_path(cube_name.clone())?;
60-
let cube_alias = if let Some(sql_alias) = &cube_definition.static_data().sql_alias {
61-
sql_alias
62-
} else {
63-
cube_name
64-
};
57+
let cube_alias = query_tools.alias_for_cube(cube_name)?;
6558
Ok(PlanSqlTemplates::memeber_alias_name(
6659
&cube_alias,
6760
&member_name,

rust/cubesqlplanner/cubesqlplanner/src/planner/planners/multiplied_measures_query_planner.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ impl MultipliedMeasuresQueryPlanner {
136136

137137
let pk_cube = self.common_utils.cube_from_path(key_cube_name.clone())?;
138138
let pk_cube_alias =
139-
pk_cube.default_alias_with_prefix(&Some(format!("{key_cube_name}_key")));
139+
pk_cube.default_alias_with_prefix(&Some(format!("{}_key", pk_cube.default_alias())));
140140
let mut ungrouped_measure_references = HashMap::new();
141141
if should_build_join_for_measure_select {
142142
let subquery = self.aggregate_subquery_measure_join(
@@ -388,7 +388,10 @@ impl MultipliedMeasuresQueryPlanner {
388388
)?;
389389

390390
let source = self.join_planner.make_join_node_impl(
391-
&Some(format!("{}_key", key_cube_name)),
391+
&Some(format!(
392+
"{}_key",
393+
self.query_tools.alias_for_cube(key_cube_name)?
394+
)),
392395
key_join,
393396
&dimension_subquery_planner,
394397
)?;

rust/cubesqlplanner/cubesqlplanner/src/planner/query_tools.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,16 @@ impl QueryTools {
229229
}
230230
}
231231

232+
pub fn alias_for_cube(&self, cube_name: &String) -> Result<String, CubeError> {
233+
let cube_definition = self.cube_evaluator().cube_from_path(cube_name.clone())?;
234+
let res = if let Some(sql_alias) = &cube_definition.static_data().sql_alias {
235+
sql_alias.clone()
236+
} else {
237+
cube_name.clone()
238+
};
239+
Ok(res)
240+
}
241+
232242
pub fn escape_column_name(&self, column_name: &str) -> String {
233243
format!("\"{}\"", column_name)
234244
}

0 commit comments

Comments
 (0)