Skip to content

Commit 546227a

Browse files
committed
fix: remove noisy Warning: Attribute filter.dimension is deprecated. Please use 'member' instead of 'dimension'
1 parent a547fe4 commit 546227a

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

packages/cubejs-api-gateway/src/query.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -200,19 +200,11 @@ const normalizeQuery = (query, persistent) => {
200200
order: normalizeQueryOrder(query.order),
201201
filters: (query.filters || []).map(f => {
202202
const { dimension, member, ...filter } = f;
203-
const normalizedFilter = {
203+
return {
204204
...filter,
205205
member: member || dimension,
206206
values: filter.values?.map(v => (v != null ? v.toString() : v))
207207
};
208-
209-
Object.defineProperty(normalizedFilter, 'dimension', {
210-
get() {
211-
console.warn('Warning: Attribute `filter.dimension` is deprecated. Please use \'member\' instead of \'dimension\'.');
212-
return this.member;
213-
}
214-
});
215-
return normalizedFilter;
216208
}),
217209
dimensions: (query.dimensions || []).filter(d => d.split('.').length !== 3),
218210
timeDimensions: (query.timeDimensions || []).map(td => {

0 commit comments

Comments
 (0)