Skip to content

Commit 5775955

Browse files
committed
tests polish
1 parent f7f697d commit 5775955

File tree

1 file changed

+10
-21
lines changed

1 file changed

+10
-21
lines changed

packages/cubejs-server-core/test/unit/RefreshScheduler.test.ts

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import R from 'ramda';
22
import { BaseDriver } from '@cubejs-backend/query-orchestrator';
3-
import { pausePromise, SchemaFileRepository } from '@cubejs-backend/shared';
4-
import { clearInterval } from 'timers';
3+
import { pausePromise, SchemaFileRepository, createPromiseLock } from '@cubejs-backend/shared';
54
import { CubejsServerCore, CompilerApi, RefreshScheduler } from '../../src';
65

76
const schemaContent = `
@@ -233,16 +232,6 @@ cube('Bar', {
233232
]),
234233
};
235234

236-
function createDeferred() {
237-
let resolve;
238-
let reject;
239-
const promise = new Promise((res, rej) => {
240-
resolve = res;
241-
reject = rej;
242-
});
243-
return { promise, resolve, reject };
244-
}
245-
246235
class MockDriver extends BaseDriver {
247236
public tables: any[] = [];
248237

@@ -864,18 +853,18 @@ describe('Refresh Scheduler', () => {
864853
}
865854
}
866855

867-
const deferred = createDeferred();
856+
const lock = createPromiseLock();
868857
const orchestrator = await serverCore.getOrchestratorApi(ctx);
869858

870859
const interval = setInterval(async () => {
871860
const queuedList = await orchestrator.getPreAggregationQueueStates();
872861

873862
if (queuedList.length === 0) {
874-
deferred.resolve();
863+
lock.resolve();
875864
}
876865
}, 500);
877866

878-
await deferred.promise;
867+
await lock.promise;
879868
clearInterval(interval);
880869

881870
expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_first') && o.timezone === 'UTC').length).toEqual(5);
@@ -923,18 +912,18 @@ describe('Refresh Scheduler', () => {
923912
}
924913
}
925914

926-
const deferred = createDeferred();
915+
const lock = createPromiseLock();
927916
const orchestrator = await serverCore.getOrchestratorApi(ctx);
928917

929918
const interval = setInterval(async () => {
930919
const queuedList = await orchestrator.getPreAggregationQueueStates();
931920

932921
if (queuedList.length === 0) {
933-
deferred.resolve();
922+
lock.resolve();
934923
}
935924
}, 500);
936925

937-
await deferred.promise;
926+
await lock.promise;
938927
clearInterval(interval);
939928

940929
expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_first') && o.timezone === 'UTC').length).toEqual(5);
@@ -976,18 +965,18 @@ describe('Refresh Scheduler', () => {
976965
}
977966
}
978967

979-
const deferred = createDeferred();
968+
const lock = createPromiseLock();
980969
const orchestrator = await serverCore.getOrchestratorApi(ctx);
981970

982971
const interval = setInterval(async () => {
983972
const queuedList = await orchestrator.getPreAggregationQueueStates();
984973

985974
if (queuedList.length === 0) {
986-
deferred.resolve();
975+
lock.resolve();
987976
}
988977
}, 500);
989978

990-
await deferred.promise;
979+
await lock.promise;
991980
clearInterval(interval);
992981

993982
expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_first') && o.timezone === 'UTC').length).toEqual(3);

0 commit comments

Comments
 (0)