Skip to content

Commit 59fc553

Browse files
committed
propagate span_id
1 parent e072ca1 commit 59fc553

File tree

8 files changed

+23
-6
lines changed

8 files changed

+23
-6
lines changed

packages/cubejs-backend-native/src/node_export.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ async fn handle_sql_query(
212212
}
213213

214214
let session_clone = Arc::clone(&session);
215+
let span_id_clone = span_id.clone();
215216

216217
let execute = || async move {
217218
// todo: can we use compiler_cache?
@@ -221,7 +222,8 @@ async fn handle_sql_query(
221222
.map_err(|err| {
222223
CubeError::internal(format!("Failed to get meta context: {}", err))
223224
})?;
224-
let query_plan = convert_sql_to_cube_query(sql_query, meta_context, session).await?;
225+
let query_plan =
226+
convert_sql_to_cube_query(sql_query, meta_context, session, span_id_clone).await?;
225227

226228
let mut stream = get_df_batches(&query_plan).await?;
227229

packages/cubejs-backend-native/src/sql4sql.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,8 @@ async fn handle_sql4sql_query(
166166
.await
167167
.map_err(|err| CubeError::internal(format!("Failed to get meta context: {err}")))?;
168168
let query_plan =
169-
convert_sql_to_cube_query(sql_query, meta_context.clone(), session.clone()).await?;
169+
convert_sql_to_cube_query(sql_query, meta_context.clone(), session.clone(), None)
170+
.await?;
170171
let logical_plan = query_plan.try_as_logical_plan()?;
171172
get_sql(&session, meta_context, Arc::new(logical_plan.clone())).await
172173
})

packages/cubejs-backend-native/src/transport.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,8 @@ impl TransportService for NodeBridgeTransport {
341341
) -> Result<Vec<RecordBatch>, CubeError> {
342342
trace!("[transport] Request ->");
343343

344+
println!("!!!! LOAD {:?}", span_id);
345+
344346
let native_auth = ctx
345347
.as_any()
346348
.downcast_ref::<NativeAuthContext>()

rust/cubesql/cubesql/src/compile/router.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,8 @@ pub async fn convert_sql_to_cube_query(
640640
query: &str,
641641
meta: Arc<MetaContext>,
642642
session: Arc<Session>,
643+
span_id: Option<Arc<SpanId>>,
643644
) -> CompilationResult<QueryPlan> {
644645
let stmt = parse_sql_to_statement(&query, session.state.protocol.clone(), &mut None)?;
645-
convert_statement_to_cube_query(stmt, meta, session, &mut None, None).await
646+
convert_statement_to_cube_query(stmt, meta, session, &mut None, span_id).await
646647
}

rust/cubesql/cubesql/src/compile/service.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ impl SqlService for SqlAuthDefaultImpl {
2727
meta: Arc<MetaContext>,
2828
session: Arc<Session>,
2929
) -> CompilationResult<QueryPlan> {
30-
convert_sql_to_cube_query(&query, meta, session).await
30+
convert_sql_to_cube_query(&query, meta, session, None).await
3131
}
3232
}

rust/cubesql/cubesql/src/compile/test/mod.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1021,7 +1021,13 @@ impl TestContext {
10211021

10221022
pub async fn convert_sql_to_cube_query(&self, query: &str) -> CompilationResult<QueryPlan> {
10231023
// TODO push to_string() deeper
1024-
convert_sql_to_cube_query(&query.to_string(), self.meta.clone(), self.session.clone()).await
1024+
convert_sql_to_cube_query(
1025+
&query.to_string(),
1026+
self.meta.clone(),
1027+
self.session.clone(),
1028+
None,
1029+
)
1030+
.await
10251031
}
10261032

10271033
pub async fn execute_query_with_flags(
@@ -1131,6 +1137,7 @@ pub async fn convert_select_to_query_plan_with_meta(
11311137
&query,
11321138
meta_context.clone(),
11331139
get_test_session(DatabaseProtocol::PostgreSQL, meta_context).await,
1140+
None,
11341141
)
11351142
.await;
11361143

rust/cubesql/cubesql/src/compile/test/test_cube_join.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,7 @@ async fn test_join_cubes_on_wrong_field_error() {
503503
.to_string(),
504504
meta.clone(),
505505
get_test_session(DatabaseProtocol::PostgreSQL, meta).await,
506+
None,
506507
)
507508
.await;
508509

@@ -527,6 +528,7 @@ async fn test_join_cubes_filter_from_wrong_side_error() {
527528
.to_string(),
528529
meta.clone(),
529530
get_test_session(DatabaseProtocol::PostgreSQL, meta).await,
531+
None
530532
)
531533
.await;
532534

@@ -554,6 +556,7 @@ async fn test_join_cubes_with_aggr_error() {
554556
.to_string(),
555557
meta.clone(),
556558
get_test_session(DatabaseProtocol::PostgreSQL, meta).await,
559+
None
557560
)
558561
.await;
559562

rust/cubesql/cubesql/src/compile/test/test_user_change.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,8 @@ async fn test_change_user_via_filter_or() {
163163
convert_sql_to_cube_query(
164164
&"SELECT COUNT(*) as cnt FROM KibanaSampleDataEcommerce WHERE __user = 'gopher' OR customer_gender = 'male'".to_string(),
165165
meta.clone(),
166-
get_test_session(DatabaseProtocol::PostgreSQL, meta).await
166+
get_test_session(DatabaseProtocol::PostgreSQL, meta).await,
167+
None
167168
).await;
168169

169170
// TODO: We need to propagate error to result, to assert message

0 commit comments

Comments
 (0)