chore: fix

Author: ovr

rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs

@@ -137,17 +137,17 @@ fn extract_group_type_from_groupping_set(
         match expr {
             Expr::GroupingSet(groupping_set) => match groupping_set {
                 GroupingSet::Rollup(exprs) => {
-                    result.extend(
-                        iter::repeat(Some(GroupingSetDesc::new(GroupingSetType::Rollup, id)))
-                            .take(exprs.len()),
-                    );
+                    result.extend(std::iter::repeat_n(
+                        Some(GroupingSetDesc::new(GroupingSetType::Rollup, id)),
+                        exprs.len(),
+                    ));
                     id += 1;
                 }
                 GroupingSet::Cube(exprs) => {
-                    result.extend(
-                        iter::repeat(Some(GroupingSetDesc::new(GroupingSetType::Cube, id)))
-                            .take(exprs.len()),
-                    );
+                    result.extend(std::iter::repeat_n(
+                        Some(GroupingSetDesc::new(GroupingSetType::Cube, id)),
+                        exprs.len(),
+                    ));
                     id += 1;
                 }
                 GroupingSet::GroupingSets(_) => {

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

@@ -2708,7 +2708,7 @@ impl MemberRules {
                             let Some(left_cube) = left_join_hints
                                 .iter()
                                 .filter(|hint| !hint.is_empty())
-                                .last()
+                                .next_back()
                                 .and_then(|hint| hint.last())
                                 .or_else(|| left_alias_to_cube.first().map(|(_, cube)| cube))
                                 .cloned()

rust/cubesql/pg-srv/src/buffer.rs

@@ -94,10 +94,7 @@ pub async fn read_contents<Reader: AsyncReadExt + Unpin>(
     // protocol defines length for all types of messages
     let length = reader.read_u32().await?;
     if length < 4 {
-        return Err(Error::new(
-            ErrorKind::Other,
-            "Unexpectedly small (<0) message size",
-        ));
+        return Err(Error::other("Unexpectedly small (<0) message size"));
     }
 
     trace!(

rust/cubesql/pg-srv/src/values/date.rs

@@ -21,13 +21,10 @@ impl ToProtocolValue for DateValue {
             .signed_duration_since(pg_base_date_epoch().date())
             .num_days();
         if n > (i32::MAX as i64) {
-            return Err(Error::new(
-                ErrorKind::Other,
-                format!(
-                    "value too large to store in the binary format (i32), actual: {}",
-                    n
-                ),
-            )
+            return Err(Error::other(format!(
+                "value too large to store in the binary format (i32), actual: {}",
+                n
+            ))
             .into());
         }
 

rust/cubesql/pg-srv/src/values/timestamp.rs

@@ -52,7 +52,7 @@ impl TimestampValue {
             .as_ref()
             .unwrap()
             .parse::<Tz>()
-            .map_err(|err| io::Error::new(io::ErrorKind::Other, err.to_string()))?;
+            .map_err(|err| io::Error::other(err.to_string()))?;
         let ndt = self.to_naive_datetime();
         Ok(tz.from_utc_datetime(&ndt))
     }
@@ -134,8 +134,7 @@ impl ToProtocolValue for TimestampValue {
         let n = ndt
             .signed_duration_since(pg_base_date_epoch())
             .num_microseconds()
-            .ok_or(Error::new(
-                io::ErrorKind::Other,
+            .ok_or(Error::other(
                 "Unable to extract number of seconds from timestamp",
             ))?;