Skip to content

Commit 5c858ac

Browse files
committed
fix tesseract skip tests
1 parent 1414e94 commit 5c858ac

File tree

1 file changed

+87
-75
lines changed

1 file changed

+87
-75
lines changed

packages/cubejs-schema-compiler/test/integration/postgres/pre-aggregations.test.ts

Lines changed: 87 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -1267,90 +1267,102 @@ describe('PreAggregations', () => {
12671267
});
12681268
});
12691269

1270-
it('non-match because of join tree difference (through the view)', async () => {
1271-
await compiler.compile();
1272-
const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
1273-
measures: [
1274-
'cards_visitors_checkins_view.count'
1275-
],
1276-
dimensions: ['cards_visitors_checkins_view.source'],
1277-
timeDimensions: [{
1278-
dimension: 'cards_visitors_checkins_view.createdAt',
1279-
granularity: 'day',
1280-
dateRange: ['2017-01-01', '2017-01-30']
1281-
}],
1282-
order: [{
1283-
id: 'cards_visitors_checkins_view.createdAt'
1284-
}, {
1285-
id: 'cards_visitors_checkins_view.source'
1286-
}],
1287-
timezone: 'America/Los_Angeles',
1288-
preAggregationsSchema: ''
1270+
if (getEnv('nativeSqlPlanner')) {
1271+
it.skip('FIXME(tesseract): non-match because of join tree difference (through the view)', () => {
1272+
// This should be fixed in Tesseract.
12891273
});
1274+
} else {
1275+
it('non-match because of join tree difference (through the view)', async () => {
1276+
await compiler.compile();
1277+
const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
1278+
measures: [
1279+
'cards_visitors_checkins_view.count'
1280+
],
1281+
dimensions: ['cards_visitors_checkins_view.source'],
1282+
timeDimensions: [{
1283+
dimension: 'cards_visitors_checkins_view.createdAt',
1284+
granularity: 'day',
1285+
dateRange: ['2017-01-01', '2017-01-30']
1286+
}],
1287+
order: [{
1288+
id: 'cards_visitors_checkins_view.createdAt'
1289+
}, {
1290+
id: 'cards_visitors_checkins_view.source'
1291+
}],
1292+
timezone: 'America/Los_Angeles',
1293+
preAggregationsSchema: ''
1294+
});
12901295

1291-
const queryAndParams = query.buildSqlAndParams();
1292-
console.log(queryAndParams);
1293-
expect((<any>query).preAggregations.preAggregationForQuery).toBeUndefined();
1296+
const queryAndParams = query.buildSqlAndParams();
1297+
console.log(queryAndParams);
1298+
expect((<any>query).preAggregations.preAggregationForQuery).toBeUndefined();
12941299

1295-
return dbRunner.evaluateQueryWithPreAggregations(query).then(res => {
1296-
expect(res).toEqual(
1297-
[
1298-
{
1299-
cards_visitors_checkins_view__count: '1',
1300-
cards_visitors_checkins_view__created_at_day: '2017-01-02T00:00:00.000Z',
1301-
cards_visitors_checkins_view__source: 'google',
1302-
},
1303-
{
1304-
cards_visitors_checkins_view__count: '1',
1305-
cards_visitors_checkins_view__created_at_day: '2017-01-02T00:00:00.000Z',
1306-
cards_visitors_checkins_view__source: null,
1307-
},
1308-
{
1309-
cards_visitors_checkins_view__count: '1',
1310-
cards_visitors_checkins_view__created_at_day: '2017-01-04T00:00:00.000Z',
1311-
cards_visitors_checkins_view__source: null,
1312-
},
1313-
{
1314-
cards_visitors_checkins_view__count: '1',
1315-
cards_visitors_checkins_view__created_at_day: '2017-01-05T00:00:00.000Z',
1316-
cards_visitors_checkins_view__source: null,
1317-
},
1318-
{
1319-
cards_visitors_checkins_view__count: '2',
1320-
cards_visitors_checkins_view__created_at_day: '2017-01-06T00:00:00.000Z',
1321-
cards_visitors_checkins_view__source: null,
1322-
},
1323-
]
1324-
);
1300+
return dbRunner.evaluateQueryWithPreAggregations(query).then(res => {
1301+
expect(res).toEqual(
1302+
[
1303+
{
1304+
cards_visitors_checkins_view__count: '1',
1305+
cards_visitors_checkins_view__created_at_day: '2017-01-02T00:00:00.000Z',
1306+
cards_visitors_checkins_view__source: 'google',
1307+
},
1308+
{
1309+
cards_visitors_checkins_view__count: '1',
1310+
cards_visitors_checkins_view__created_at_day: '2017-01-02T00:00:00.000Z',
1311+
cards_visitors_checkins_view__source: null,
1312+
},
1313+
{
1314+
cards_visitors_checkins_view__count: '1',
1315+
cards_visitors_checkins_view__created_at_day: '2017-01-04T00:00:00.000Z',
1316+
cards_visitors_checkins_view__source: null,
1317+
},
1318+
{
1319+
cards_visitors_checkins_view__count: '1',
1320+
cards_visitors_checkins_view__created_at_day: '2017-01-05T00:00:00.000Z',
1321+
cards_visitors_checkins_view__source: null,
1322+
},
1323+
{
1324+
cards_visitors_checkins_view__count: '2',
1325+
cards_visitors_checkins_view__created_at_day: '2017-01-06T00:00:00.000Z',
1326+
cards_visitors_checkins_view__source: null,
1327+
},
1328+
]
1329+
);
1330+
});
13251331
});
1326-
});
1332+
}
13271333

1328-
it('non-match because of requesting only joined cube members', async () => {
1329-
await compiler.compile();
1330-
const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
1331-
dimensions: ['visitor_checkins.source'],
1332-
order: [{
1333-
id: 'visitor_checkins.source'
1334-
}],
1335-
timezone: 'America/Los_Angeles',
1336-
preAggregationsSchema: ''
1334+
if (getEnv('nativeSqlPlanner')) {
1335+
it.skip('FIXME(tesseract): non-match because of requesting only joined cube members', () => {
1336+
// This should be fixed in Tesseract.
13371337
});
1338+
} else {
1339+
it('non-match because of requesting only joined cube members', async () => {
1340+
await compiler.compile();
1341+
const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
1342+
dimensions: ['visitor_checkins.source'],
1343+
order: [{
1344+
id: 'visitor_checkins.source'
1345+
}],
1346+
timezone: 'America/Los_Angeles',
1347+
preAggregationsSchema: ''
1348+
});
13381349

1339-
const queryAndParams = query.buildSqlAndParams();
1340-
console.log(queryAndParams);
1341-
expect((<any>query).preAggregations.preAggregationForQuery).toBeUndefined();
1350+
const queryAndParams = query.buildSqlAndParams();
1351+
console.log(queryAndParams);
1352+
expect((<any>query).preAggregations.preAggregationForQuery).toBeUndefined();
13421353

1343-
return dbRunner.evaluateQueryWithPreAggregations(query).then(res => {
1344-
expect(res).toEqual([
1345-
{
1346-
vc__source: 'google',
1347-
},
1348-
{
1349-
vc__source: null,
1350-
},
1351-
]);
1354+
return dbRunner.evaluateQueryWithPreAggregations(query).then(res => {
1355+
expect(res).toEqual([
1356+
{
1357+
vc__source: 'google',
1358+
},
1359+
{
1360+
vc__source: null,
1361+
},
1362+
]);
1363+
});
13521364
});
1353-
});
1365+
}
13541366

13551367
it('non-leaf additive measure', async () => {
13561368
await compiler.compile();

0 commit comments

Comments
 (0)