refactor(base-driver): Enable noImplicitAny (#6529)

Author: ovr

packages/cubejs-base-driver/src/BaseDriver.ts

@@ -37,8 +37,8 @@ import {
   DriverCapabilities
 } from './driver.interface';
 
-const sortByKeys = (unordered) => {
-  const ordered = {};
+const sortByKeys = (unordered: any) => {
+  const ordered: any = {};
 
   Object.keys(unordered).sort().forEach((key) => {
     ordered[key] = unordered[key];
@@ -47,7 +47,7 @@ const sortByKeys = (unordered) => {
   return ordered;
 };
 
-const DbTypeToGenericType = {
+const DbTypeToGenericType: Record<string, string> = {
   'timestamp without time zone': 'timestamp',
   'character varying': 'text',
   varchar: 'text',
@@ -78,7 +78,7 @@ const DB_INT_MAX = 2147483647;
 const DB_INT_MIN = -2147483648;
 
 // Order of keys is important here: from more specific to less specific
-const DbTypeValueMatcher = {
+const DbTypeValueMatcher: Record<string, ((v: any) => boolean)> = {
   timestamp: (v) => v instanceof Date || v.toString().match(/^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d/),
   date: (v) => v instanceof Date || v.toString().match(/^\d\d\d\d-\d\d-\d\d$/),
   int: (v) => {
@@ -268,7 +268,7 @@ export abstract class BaseDriver implements DriverInterface {
     return false;
   }
 
-  protected informationColumnsSchemaReducer(result, i) {
+  protected informationColumnsSchemaReducer(result: any, i: any) {
     let schema = (result[i.table_schema] || {});
     const tables = (schema[i.table_name] || []);
 
@@ -306,7 +306,7 @@ export abstract class BaseDriver implements DriverInterface {
     );
   }
 
-  public loadPreAggregationIntoTable(_preAggregationTableName: string, loadSql: string, params, options) {
+  public loadPreAggregationIntoTable(_preAggregationTableName: string, loadSql: string, params: any, options: any) {
     return this.query(loadSql, params, options);
   }
 
@@ -407,15 +407,15 @@ export abstract class BaseDriver implements DriverInterface {
     return `"${identifier}"`;
   }
 
-  protected cancelCombinator(fn) {
+  protected cancelCombinator(fn: any) {
     return cancelCombinator(fn);
   }
 
-  public setLogger(logger) {
+  public setLogger(logger: any) {
     this.logger = logger;
   }
 
-  protected reportQueryUsage(usage, queryOptions) {
+  protected reportQueryUsage(usage: any, queryOptions: any) {
     if (this.logger) {
       this.logger('SQL Query Usage', {
         ...usage,
@@ -424,7 +424,7 @@ export abstract class BaseDriver implements DriverInterface {
     }
   }
 
-  protected databasePoolError(error) {
+  protected databasePoolError(error: any) {
     if (this.logger) {
       this.logger('Database Pool Error', {
         error: (error.stack || error).toString()

packages/cubejs-base-driver/src/cache-driver.interface.ts

@@ -2,7 +2,7 @@ import { CancelablePromise, MaybeCancelablePromise } from '@cubejs-backend/share
 
 export interface CacheDriverInterface {
   get(key: string): Promise<any>;
-  set(key: string, value, expiration): Promise<{
+  set(key: string, value: unknown, expiration: number): Promise<{
     key: string;
     bytes: number;
   }>;

packages/cubejs-base-driver/src/queue-driver.interface.ts

@@ -48,6 +48,8 @@ export interface QueueDriverOptions {
   processUid?: string;
 }
 
+export type ProcessingId = string | number;
+
 export interface QueueDriverConnectionInterface {
   redisHash(queryKey: QueryKey): QueryKeyHash;
   getResultBlocking(queryKey: QueryKey): Promise<unknown>;
@@ -80,7 +82,7 @@ export interface QueueDriverConnectionInterface {
   // multiple nodes tries to process the same query
   retrieveForProcessing(hash: QueryKeyHash, processingId: number | string): Promise<RetrieveForProcessingResponse>;
   freeProcessingLock(hash: QueryKeyHash, processingId: string | number, activated: unknown): Promise<void>;
-  optimisticQueryUpdate(hash: QueryKeyHash, toUpdate, processingId): Promise<boolean>;
+  optimisticQueryUpdate(hash: QueryKeyHash, toUpdate: unknown, processingId: ProcessingId): Promise<boolean>;
   cancelQuery(queryKey: QueryKey): Promise<QueryDef | null>;
   getQueryAndRemove(hash: QueryKeyHash): Promise<[QueryDef]>;
   setResultAndRemoveQuery(hash: QueryKeyHash, executionResult: any, processingId: any): Promise<unknown>;

packages/cubejs-base-driver/src/utils.ts

@@ -2,7 +2,7 @@ import { CancelablePromiseCancel, MaybeCancelablePromise } from '@cubejs-backend
 
 export type SaveCancelFn = <T>(promise: MaybeCancelablePromise<T>) => Promise<T>;
 
-export function cancelCombinator(fn) {
+export function cancelCombinator(fn: any) {
   const cancelFnArray: CancelablePromiseCancel[] = [];
 
   const saveCancelFn: SaveCancelFn = (promise) => {

packages/cubejs-base-driver/test/unit/BaseDriver.test.ts

@@ -8,7 +8,7 @@ class BaseDriverImplementedMock extends BaseDriver {
   // eslint-disable-next-line @typescript-eslint/no-empty-function
   public async testConnection(): Promise<void> {}
 
-  public async query(_query, _values) {
+  public async query(_query: string, _values: unknown[]) {
     return this.response;
   }
 }

packages/cubejs-base-driver/tsconfig.json

@@ -8,7 +8,6 @@
     "outDir": "dist",
     "rootDir": ".",
     "baseUrl": ".",
-    "allowJs": true,
-    "noImplicitAny": false
+    "allowJs": true
   },
 }