tests

Author: KSDaemon

packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts

@@ -129,6 +129,15 @@ describe('SQL Generation', () => {
             type: 'prior',
           }]
         },
+        revenue_day_ago_no_td: {
+          multi_stage: true,
+          type: 'sum',
+          sql: \`\${revenue}\`,
+          time_shift: [{
+            interval: '1 day',
+            type: 'prior',
+          }]
+        },
         cagr_day: {
           multi_stage: true,
           sql: \`ROUND(100 * \${revenue} / NULLIF(\${revenue_day_ago}, 0))\`,
@@ -1347,6 +1356,26 @@ SELECT 1 AS revenue,  cast('2024-01-01' AS timestamp) as time UNION ALL
     { visitors__created_at_day: '2017-01-06T00:00:00.000Z', visitors__cagr_day: '300', visitors__revenue: '900', visitors__revenue_day_ago: '300' }
   ]));
 
+  it('CAGR (no td in time_shift)', async () => runQueryTest({
+    measures: [
+      'visitors.revenue',
+      'visitors.revenue_day_ago_no_td',
+      'visitors.cagr_day'
+    ],
+    timeDimensions: [{
+      dimension: 'visitors.created_at',
+      granularity: 'day',
+      dateRange: ['2016-12-01', '2017-01-31']
+    }],
+    order: [{
+      id: 'visitors.created_at'
+    }],
+    timezone: 'America/Los_Angeles'
+  }, [
+    { visitors__created_at_day: '2017-01-05T00:00:00.000Z', visitors__cagr_day: '150', visitors__revenue: '300', visitors__revenue_day_ago_no_td: '200' },
+    { visitors__created_at_day: '2017-01-06T00:00:00.000Z', visitors__cagr_day: '300', visitors__revenue: '900', visitors__revenue_day_ago_no_td: '300' }
+  ]));
+
   it('sql utils', async () => runQueryTest({
     measures: [
       'visitors.visitor_count'

packages/cubejs-schema-compiler/test/unit/cube-validator.test.ts

@@ -251,27 +251,136 @@ describe('Cube Validation', () => {
     expect(validationResult.error).toBeTruthy();
   });
 
-  it('measures alternatives', async () => {
-    const cubeValidator = new CubeValidator(new CubeSymbols());
-    const cube = {
-      name: 'name',
-      sql: () => '',
-      fileName: 'fileName',
-      measures: {
-        number: {
-          type: 'suma'
+  describe('Measures', () => {
+    it('measures alternatives', async () => {
+      const cubeValidator = new CubeValidator(new CubeSymbols());
+      const cube = {
+        name: 'name',
+        sql: () => '',
+        fileName: 'fileName',
+        measures: {
+          number: {
+            type: 'suma'
+          }
         }
-      }
-    };
+      };
 
-    const validationResult = cubeValidator.validate(cube, {
-      error: (message: any, _e: any) => {
-        console.log(message);
-        expect(message).toContain('must be one of [count, number,');
-      }
-    } as any);
+      const validationResult = cubeValidator.validate(cube, {
+        error: (message: any, _e: any) => {
+          console.log(message);
+          expect(message).toContain('must be one of [count, number,');
+        }
+      } as any);
 
-    expect(validationResult.error).toBeTruthy();
+      expect(validationResult.error).toBeTruthy();
+    });
+
+    it('2 timeShifts, 1 without timeDimension', async () => {
+      const cubeValidator = new CubeValidator(new CubeSymbols());
+      const cube = {
+        name: 'name',
+        sql: () => '',
+        fileName: 'fileName',
+        measures: {
+          measure_with_time_shift: {
+            multiStage: true,
+            type: 'sum',
+            sql: () => '',
+            timeShift: [
+              {
+                timeDimension: () => '',
+                interval: '1 day',
+                type: 'prior',
+              },
+              {
+                interval: '1 day',
+                type: 'prior',
+              }
+            ]
+          }
+        }
+      };
+
+      const validationResult = cubeValidator.validate(cube, {
+        error: (message: any, _e: any) => {
+          console.log(message);
+          expect(message).toContain('(measures.measure_with_time_shift.timeShift[1].timeDimension) is required');
+        }
+      } as any);
+
+      expect(validationResult.error).toBeTruthy();
+    });
+
+    it('3 timeShifts', async () => {
+      const cubeValidator = new CubeValidator(new CubeSymbols());
+      const cube = {
+        name: 'name',
+        sql: () => '',
+        fileName: 'fileName',
+        measures: {
+          measure_with_time_shift: {
+            multiStage: true,
+            type: 'sum',
+            sql: () => '',
+            timeShift: [
+              {
+                timeDimension: () => '',
+                interval: '1 day',
+                type: 'prior',
+              },
+              {
+                timeDimension: () => '',
+                interval: '1 year',
+                type: 'next',
+              },
+              {
+                timeDimension: () => '',
+                interval: '1 week',
+                type: 'prior',
+              }
+            ]
+          }
+        }
+      };
+
+      const validationResult = cubeValidator.validate(cube, {
+        error: (message: any, _e: any) => {
+          console.log(message);
+        }
+      } as any);
+
+      expect(validationResult.error).toBeFalsy();
+    });
+
+    it('1 timeShift without timeDimension', async () => {
+      const cubeValidator = new CubeValidator(new CubeSymbols());
+      const cube = {
+        name: 'name',
+        sql: () => '',
+        fileName: 'fileName',
+        measures: {
+          measure_with_time_shift: {
+            multiStage: true,
+            type: 'sum',
+            sql: () => '',
+            timeShift: [
+              {
+                interval: '1 day',
+                type: 'prior',
+              }
+            ]
+          }
+        }
+      };
+
+      const validationResult = cubeValidator.validate(cube, {
+        error: (message: any, _e: any) => {
+          console.log(message);
+        }
+      } as any);
+
+      expect(validationResult.error).toBeFalsy();
+    });
   });
 
   it('OriginalSqlSchema', async () => {