fix(client-vue3): Prevent heuristic call when initial query is empty in computed property validateQuery (#9656)

Co-authored-by: Konstantin Burkalev <[email protected]>

Author: AyHaski

packages/cubejs-client-vue3/src/QueryBuilder.js

@@ -395,7 +395,7 @@ export default {
       }
 
       // query heuristics should only apply on query change (not applied to the initial query)
-      if (this.prevValidatedQuery !== null) {
+      if (this.prevValidatedQuery !== null && isQueryPresent(validatedQuery)) {
         this.skipHeuristics = false;
       }
 

packages/cubejs-client-vue3/tests/unit/QueryBuilder.spec.js

@@ -1002,6 +1002,56 @@ describe('QueryBuilder.vue', () => {
         expect(wrapper.vm.prevValidatedQuery.measures).not.toEqual(initialValidatedQuery.measures);
         expect(wrapper.vm.prevValidatedQuery.dimensions).toEqual(initialValidatedQuery.dimensions);
       });
+
+      it('should not set skipHeuristics to false if query is empty', async () => {
+        const cube = createCubeApi();
+        jest
+          .spyOn(cube, 'request')
+          .mockImplementation(fetchMock(load))
+          .mockImplementationOnce(fetchMock(meta));
+
+        const wrapper = shallowMount(QueryBuilder, {
+          propsData: {
+            cubeApi: cube,
+            query: {},
+          },
+        });
+
+        await flushPromises();
+
+        expect(wrapper.vm.skipHeuristics).toBeTruthy();
+      });
+      it('should set skipHeuristics to false if query is not empty and prevValidateQuery is not null', async () => {
+        const cube = createCubeApi();
+        jest
+          .spyOn(cube, 'request')
+          .mockImplementation(fetchMock(load))
+          .mockImplementationOnce(fetchMock(meta));
+
+        const wrapper = shallowMount(QueryBuilder, {
+          propsData: {
+            cubeApi: cube,
+            query: {
+              measures: ['Orders.count'],
+              timeDimensions: [
+                {
+                  dimension: 'Orders.createdAt',
+                },
+              ],
+            },
+          },
+        });
+
+        const initialValidatedQuery = {
+          measures: ['measure1'],
+          dimensions: ['dimension1'],
+        };
+        wrapper.setData({ prevValidatedQuery: initialValidatedQuery });
+
+        await flushPromises();
+
+        expect(wrapper.vm.skipHeuristics).toBeFalsy();
+      });
     });
     describe('orderMembers', () => {
       it('does not contain time dimension if granularity is set to none', async () => {