fix(cubesql): Window PARTITION BY, ORDER BY queries fail for SQL push down

Author: paveltiunov

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

@@ -2483,7 +2483,7 @@ class BaseQuery {
         binary: '({{ left }} {{ op }} {{ right }})',
         sort: '{{ expr }} {% if asc %}ASC{% else %}DESC{% endif %}{% if nulls_first %} NULLS FIRST{% endif %}',
         cast: 'CAST({{ expr }} AS {{ data_type }})',
-        window_function: '{{ fun_call }} OVER ({% if partition_by %}PARTITION BY {{ partition_by }}{% if order_by %} {% endif %}{% endif %}{% if order_by %}ORDER BY {{ order_by }}{% endif %})',
+        window_function: '{{ fun_call }} OVER ({% if partition_by_concat %}PARTITION BY {{ partition_by_concat }}{% if order_by_concat %} {% endif %}{% endif %}{% if order_by_concat %}ORDER BY {{ order_by_concat }}{% endif %})',
         in_list: '{{ expr }} {% if negated %}NOT {% endif %}IN ({{ in_exprs_concat }})',
       },
       quotes: {

rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs

@@ -1398,18 +1398,7 @@ impl CubeScanWrapperNode {
                         )
                         .await?;
                         sql_query = query;
-                        sql_order_by.push(
-                            sql_generator
-                                .get_sql_templates()
-                                // TODO asc/desc
-                                .sort_expr(sql, true, false)
-                                .map_err(|e| {
-                                    DataFusionError::Internal(format!(
-                                        "Can't generate SQL for sort expr: {}",
-                                        e
-                                    ))
-                                })?,
-                        );
+                        sql_order_by.push(sql);
                     }
                     let resulting_sql = sql_generator
                         .get_sql_templates()