Skip to content

Commit 67565b9

Browse files
authored
feat(snowflake-driver): streaming export, read-only unload (#6452)
1 parent 47d566f commit 67565b9

File tree

16 files changed

+7704
-156
lines changed

16 files changed

+7704
-156
lines changed

.github/workflows/drivers-tests.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ on:
1717
- 'packages/cubejs-mssql-driver/**'
1818
- 'packages/cubejs-mysql-driver/**'
1919
- 'packages/cubejs-postgres-driver/**'
20+
- 'packages/cubejs-snowflake-driver/**'
2021
pull_request:
2122
paths:
2223
- '.github/workflows/drivers-tests.yml'
@@ -31,6 +32,7 @@ on:
3132
- 'packages/cubejs-mssql-driver/**'
3233
- 'packages/cubejs-mysql-driver/**'
3334
- 'packages/cubejs-postgres-driver/**'
35+
- 'packages/cubejs-snowflake-driver/**'
3436

3537
jobs:
3638
build:
@@ -78,6 +80,7 @@ jobs:
7880
- mssql
7981
- mysql
8082
- postgres
83+
- snowflake
8184
suite:
8285
- driver
8386
- core
@@ -136,6 +139,10 @@ jobs:
136139
DRIVERS_TESTS_CUBEJS_DB_DATABRICKS_TOKEN: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_DATABRICKS_TOKEN }}
137140
DRIVERS_TESTS_CUBEJS_DB_EXPORT_BUCKET_AWS_KEY: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_EXPORT_BUCKET_AWS_KEY }}
138141
DRIVERS_TESTS_CUBEJS_DB_EXPORT_BUCKET_AWS_SECRET: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_EXPORT_BUCKET_AWS_SECRET }}
142+
143+
# Snowflake
144+
DRIVERS_TESTS_CUBEJS_DB_USER: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_USER }}
145+
DRIVERS_TESTS_CUBEJS_DB_PASS: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_PASS }}
139146
run: |
140147
cd ./packages/cubejs-testing-drivers
141148
export DEBUG=testcontainers

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"tsc:watch": "tsc --build --watch",
2525
"clean": "rimraf packages/*/{tsconfig.tsbuildinfo,lib,dist}",
2626
"postinstall": "lerna link && patch-package",
27-
"link:dev": "cd packages/cubejs-backend-shared && cd ../cubejs-backend-shared && yarn link && cd ../cubejs-backend-cloud && yarn link && cd ../cubejs-backend-native && yarn link && cd ../cubejs-server && yarn link && cd ../cubejs-server-core && yarn link && cd ../cubejs-api-gateway && yarn link && cd ../cubejs-schema-compiler && yarn link && cd ../cubejs-query-orchestrator && yarn link && cd ../cubejs-athena-driver && yarn link && cd ../cubejs-bigquery-driver && yarn link && cd ../cubejs-postgres-driver && yarn link && cd ../cubejs-databricks-jdbc-driver && yarn link && cd ../cubejs-mssql-driver && yarn link && cd ../cubejs-clickhouse-driver && yarn link && cd ../cubejs-templates && yarn link && cd ../cubejs-client-core && yarn link && cd ../cubejs-client-ws-transport && yarn link && cd ../cubejs-playground && yarn link"
27+
"link:dev": "cd packages/cubejs-backend-shared && cd ../cubejs-backend-shared && yarn link && cd ../cubejs-backend-cloud && yarn link && cd ../cubejs-backend-native && yarn link && cd ../cubejs-server && yarn link && cd ../cubejs-server-core && yarn link && cd ../cubejs-api-gateway && yarn link && cd ../cubejs-schema-compiler && yarn link && cd ../cubejs-query-orchestrator && yarn link && cd ../cubejs-athena-driver && yarn link && cd ../cubejs-bigquery-driver && yarn link && cd ../cubejs-postgres-driver && yarn link && cd ../cubejs-databricks-jdbc-driver && yarn link && cd ../cubejs-mssql-driver && yarn link && cd ../cubejs-clickhouse-driver && yarn link && cd ../cubejs-snowflake-driver && yarn link && cd ../cubejs-cubestore-driver && yarn link && cd ../cubejs-templates && yarn link && cd ../cubejs-client-core && yarn link && cd ../cubejs-client-ws-transport && yarn link && cd ../cubejs-playground && yarn link"
2828
},
2929
"author": "Cube Dev, Inc.",
3030
"dependencies": {

packages/cubejs-athena-driver/src/AthenaDriver.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ export class AthenaDriver extends BaseDriver implements DriverInterface {
256256
}
257257

258258
/**
259-
* Executes query and rerutns queried raws.
259+
* Executes query and rerutns queried rows.
260260
*/
261261
public async query<R = unknown>(
262262
query: string,
@@ -363,7 +363,7 @@ export class AthenaDriver extends BaseDriver implements DriverInterface {
363363
exportBucketCsvEscapeSymbol: this.config.exportBucketCsvEscapeSymbol,
364364
csvFile,
365365
types,
366-
csvNoHeader: true
366+
csvNoHeader: true,
367367
};
368368
}
369369

0 commit comments

Comments
 (0)