Skip to content

Commit 69bf88b

Browse files
committed
more type annotations in baseQuery
1 parent c50633b commit 69bf88b

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3066,16 +3066,26 @@ export class BaseQuery {
30663066
return sql;
30673067
}
30683068

3069+
/**
3070+
* @param {string} sql
3071+
* @returns {string}
3072+
*/
30693073
wrapSegmentForDimensionSelect(sql) {
30703074
return sql;
30713075
}
30723076

3077+
/**
3078+
* @param {string} cubeName
3079+
*/
30733080
pushCubeNameForCollectionIfNecessary(cubeName) {
30743081
if ((this.evaluateSymbolContext || {}).cubeNames && cubeName) {
30753082
this.evaluateSymbolContext.cubeNames.push(cubeName);
30763083
}
30773084
}
30783085

3086+
/**
3087+
* @param {string|Array<string>} joinHints
3088+
*/
30793089
pushJoinHints(joinHints) {
30803090
if (this.safeEvaluateSymbolContext().joinHints && joinHints) {
30813091
if (Array.isArray(joinHints) && joinHints.length === 1) {
@@ -3085,6 +3095,10 @@ export class BaseQuery {
30853095
}
30863096
}
30873097

3098+
/**
3099+
* @param {string} cubeName
3100+
* @param {string} name
3101+
*/
30883102
pushMemberNameForCollectionIfNecessary(cubeName, name) {
30893103
const pathFromArray = this.cubeEvaluator.pathFromArray([cubeName, name]);
30903104
if (!this.cubeEvaluator.getCubeDefinition(cubeName).isView) {

0 commit comments

Comments
 (0)