Skip to content

Commit 70a36d8

Browse files
authored
feat(firebolt-driver): Use driver's own test connection method, thanks @ptiurin (#8815)
1 parent a8f48f2 commit 70a36d8

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

packages/cubejs-firebolt-driver/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"@cubejs-backend/base-driver": "^1.0.0",
3232
"@cubejs-backend/schema-compiler": "^1.0.0",
3333
"@cubejs-backend/shared": "^1.0.0",
34-
"firebolt-sdk": "^1.2.0"
34+
"firebolt-sdk": "^1.8.0"
3535
},
3636
"license": "Apache-2.0",
3737
"devDependencies": {

packages/cubejs-firebolt-driver/src/FireboltDriver.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ export class FireboltDriver extends BaseDriver implements DriverInterface {
170170

171171
public async testConnection(): Promise<void> {
172172
try {
173-
await this.query('select 1');
173+
const connection = await this.getConnection();
174+
await connection.testConnection();
174175
} catch (error) {
175176
console.log(error);
176177
throw new Error('Unable to connect');

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16501,10 +16501,10 @@ find-yarn-workspace-root@^2.0.0:
1650116501
dependencies:
1650216502
micromatch "^4.0.2"
1650316503

16504-
firebolt-sdk@^1.2.0:
16505-
version "1.4.0"
16506-
resolved "https://registry.yarnpkg.com/firebolt-sdk/-/firebolt-sdk-1.4.0.tgz#13a2b54a3b4265179c484e3bb8a37e15880aee1b"
16507-
integrity sha512-ZAFDtlpyoR4BJZPgem3aZEzpssVe39lAWCzsMDMw7KKFUJzqeMA7ARL99puB5bDcMzLBteGDR1S8iyPkwLTJsA==
16504+
firebolt-sdk@^1.8.0:
16505+
version "1.8.0"
16506+
resolved "https://registry.yarnpkg.com/firebolt-sdk/-/firebolt-sdk-1.8.0.tgz#f2366f28608b40db688f30505a20fba393f10aae"
16507+
integrity sha512-jQBh6a8xxkRQyjwliJ7l/1jHG3pn5367mhDP2UrMKqDmkWQl4qKngcQB7RMT3I9bsUJmwvHMe4ym5pOo8ZIPyA==
1650816508
dependencies:
1650916509
"@types/json-bigint" "^1.0.1"
1651016510
abort-controller "^3.0.0"

0 commit comments

Comments
 (0)