Skip to content

Commit 71dbca4

Browse files
authored
feat(cubestore-driver): Support timestamp(3) as a column type (#6324)
1 parent 69ef0b6 commit 71dbca4

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

.github/workflows/cloud.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,25 @@
11
# CAUTION: This workflow exposes secrets. It is only supposed to be run on "merge into master" condition.
22
name: 'Cloud Tests'
33
on:
4+
# push doesn't work for PRs, it's safe to use it
5+
# only maintainers/core contributors are allowed to push directly to the main repository
46
push:
57
paths:
6-
- '.github/actions/integration/**'
8+
- '.github/actions/integration/athena.sh'
9+
- '.github/actions/integration/bigquery.sh'
710
- '.github/workflows/cloud.yml'
8-
- 'packages/**'
9-
- '.eslintrc.js'
10-
- '.prettierrc'
11+
- 'packages/cubejs-testing/**'
12+
- 'packages/cubejs-testing-shared/**'
13+
- 'packages/cubejs-backend-shared/**'
14+
- 'packages/cubejs-base-driver/**'
15+
- 'packages/cubejs-query-orchestrator/**'
16+
- 'packages/cubejs-schema-compiler/**'
17+
# drivers
18+
- 'packages/cubejs-athena-driver/**'
19+
- 'packages/cubejs-bigquery-driver/**'
1120
- 'lerna.json'
1221
- 'package.json'
13-
- 'rollup.config.js'
1422
- 'yarn.lock'
15-
- 'docs-gen/**'
16-
- 'docs/**'
17-
branches:
18-
- master
1923

2024
jobs:
2125
integration-cloud:

packages/cubejs-athena-driver/src/AthenaDriver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
DownloadTableCSVData,
2121
DriverInterface,
2222
QueryOptions, StreamOptions,
23-
StreamTableData, TableName
23+
StreamTableData
2424
} from '@cubejs-backend/base-driver';
2525
import * as SqlString from 'sqlstring';
2626
import { AthenaClientConfig } from '@aws-sdk/client-athena/dist-types/AthenaClient';

packages/cubejs-cubestore-driver/src/CubeStoreDriver.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ import { WebSocketConnection } from './WebSocketConnection';
2424
const GenericTypeToCubeStore: Record<string, string> = {
2525
string: 'varchar(255)',
2626
text: 'varchar(255)',
27-
uuid: 'varchar(64)'
27+
uuid: 'varchar(64)',
28+
// Cube Store uses an old version of sql parser which doesn't support timestamp with custom precision, but
29+
// athena driver (I believe old version) allowed to use it
30+
'timestamp(3)': 'timestamp',
2831
};
2932

3033
type Column = {

0 commit comments

Comments
 (0)