Skip to content

Commit 7545e49

Browse files
committed
code polishment
1 parent fa08b2e commit 7545e49

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

packages/cubejs-databricks-jdbc-driver/src/DatabricksDriver.ts

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,21 @@
44
* @fileoverview The `DatabricksDriver` and related types declaration.
55
*/
66

7+
import { assertDataSource, getEnv, } from '@cubejs-backend/shared';
78
import {
8-
getEnv,
9-
assertDataSource,
10-
} from '@cubejs-backend/shared';
11-
import {
9+
DatabaseStructure,
1210
DriverCapabilities,
11+
GenericDataBaseType,
1312
QueryColumnsResult,
1413
QueryOptions,
1514
QuerySchemasResult,
1615
QueryTablesResult,
17-
UnloadOptions,
18-
GenericDataBaseType,
1916
TableColumn,
20-
DatabaseStructure,
17+
UnloadOptions,
2118
} from '@cubejs-backend/base-driver';
22-
import {
23-
JDBCDriver,
24-
JDBCDriverConfiguration,
25-
} from '@cubejs-backend/jdbc-driver';
19+
import { JDBCDriver, JDBCDriverConfiguration, } from '@cubejs-backend/jdbc-driver';
2620
import { DatabricksQuery } from './DatabricksQuery';
27-
import { resolveJDBCDriver, extractUidFromJdbcUrl } from './helpers';
21+
import { extractUidFromJdbcUrl, resolveJDBCDriver } from './helpers';
2822

2923
export type DatabricksDriverConfiguration = JDBCDriverConfiguration &
3024
{
@@ -132,7 +126,7 @@ export class DatabricksDriver extends JDBCDriver {
132126
/**
133127
* Show warning message flag.
134128
*/
135-
private showSparkProtocolWarn: boolean;
129+
private readonly showSparkProtocolWarn: boolean;
136130

137131
/**
138132
* Driver Configuration.
@@ -429,8 +423,7 @@ export class DatabricksDriver extends JDBCDriver {
429423
metadata[database] = {};
430424
}
431425

432-
const columns = await this.tableColumnTypes(`${database}.${tableName}`);
433-
metadata[database][tableName] = columns;
426+
metadata[database][tableName] = await this.tableColumnTypes(`${database}.${tableName}`);
434427
}));
435428

436429
return metadata;

0 commit comments

Comments
 (0)