Skip to content

Commit 786f846

Browse files
authored
Merge branch 'master' into vertica_driver
2 parents 7fa80a6 + 4b85612 commit 786f846

File tree

4 files changed

+40
-2
lines changed

4 files changed

+40
-2
lines changed

docs/pages/product/caching/running-in-production.mdx

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,28 @@ Refresh worker should be able to finish pre-aggregation refresh before
325325
garbage collection starts. It means that all pre-aggregation partitions
326326
should be built before any tables are removed.
327327

328+
#### Supported file systems
329+
330+
The garbage collection mechanism relies on the ability of the underlying file
331+
system to report the creation time of a file.
332+
333+
If the file system does not support getting the creation time, you will see the
334+
following error message in Cube Store logs:
335+
336+
```
337+
ERROR [cubestore::remotefs::cleanup] <pid:1>
338+
error while getting created time for file "<name>.chunk.parquet":
339+
creation time is not available for the filesystem
340+
```
341+
342+
<ReferenceBox>
343+
344+
XFS is known to not support getting the creation time of a file.
345+
Please see [this issue](https://github.com/cube-js/cube/issues/7905#issuecomment-2504212623)
346+
for possible workarounds.
347+
348+
</ReferenceBox>
349+
328350
## Security
329351

330352
### Authentication

docs/pages/reference/data-model/pre-aggregations.mdx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1635,6 +1635,13 @@ cubes:
16351635
16361636
</CodeTabs>
16371637
1638+
<ReferenceBox>
1639+
1640+
In some cases, indexes would not work with `original_sql` pre-aggregations.
1641+
Please [track this issue](https://github.com/cube-js/cube/issues/7420).
1642+
1643+
</ReferenceBox>
1644+
16381645
#### `type`
16391646

16401647
This option is used to define [aggregating indexes][ref-aggregating-indexes]

packages/cubejs-ksql-driver/src/KsqlDriver.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,9 @@ export class KsqlDriver extends BaseDriver implements DriverInterface {
131131
if (this.config.kafkaHost) {
132132
this.kafkaClient = new Kafka({
133133
clientId: 'Cube',
134-
brokers: [this.config.kafkaHost],
134+
brokers: this.config.kafkaHost
135+
.split(',')
136+
.map(h => h.trim()),
135137
// authenticationTimeout: 10000,
136138
// reauthenticationThreshold: 10000,
137139
ssl: this.config.kafkaUseSsl,

rust/cubestore/cubestore/src/streaming/kafka.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,13 @@ impl StreamingSource for KafkaStreamingSource {
306306
let unique_key_columns = self.unique_key_columns.clone();
307307
let seq_column_index_to_move = self.seq_column_index;
308308
let traffic_sender = TrafficSender::new(self.trace_obj.clone());
309+
let hosts = self
310+
.host
311+
.clone()
312+
.split(",")
313+
.filter(|s| !s.is_empty())
314+
.map(|s| s.trim().to_string())
315+
.collect();
309316
let stream = self
310317
.kafka_client
311318
.create_message_stream(
@@ -321,7 +328,7 @@ impl StreamingSource for KafkaStreamingSource {
321328
})
322329
.unwrap_or(Offset::End),
323330
),
324-
vec![self.host.clone()],
331+
hosts,
325332
&self.user,
326333
&self.password,
327334
self.use_ssl,

0 commit comments

Comments
 (0)