Skip to content

Commit 7971fe5

Browse files
committed
chore: fix
1 parent ed27d4d commit 7971fe5

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export interface QueryCacheOptions {
115115
}>;
116116
cubeStoreDriverFactory?: () => Promise<CubeStoreDriver>,
117117
continueWaitTimeout?: number;
118-
cacheAndQueueDriver?: CacheAndQueryDriverType;
118+
cacheAndQueueDriver: CacheAndQueryDriverType;
119119
maxInMemoryCacheEntries?: number;
120120
skipExternalCacheAndQueue?: boolean;
121121
}
@@ -133,9 +133,9 @@ export class QueryCache {
133133
protected readonly redisPrefix: string,
134134
protected readonly driverFactory: DriverFactoryByDataSource,
135135
protected readonly logger: any,
136-
public readonly options: QueryCacheOptions = {}
136+
public readonly options: QueryCacheOptions
137137
) {
138-
switch (options.cacheAndQueueDriver || 'memory') {
138+
switch (options.cacheAndQueueDriver) {
139139
case 'memory':
140140
this.cacheDriver = new LocalCacheDriver();
141141
break;

packages/cubejs-query-orchestrator/src/orchestrator/QueryQueue.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { TimeoutError } from './TimeoutError';
1515
import { ContinueWaitError } from './ContinueWaitError';
1616
import { LocalQueueDriver } from './LocalQueueDriver';
1717
import { QueryStream } from './QueryStream';
18+
import {CacheAndQueryDriverType} from "./QueryOrchestrator";
1819

1920
export type CancelHandlerFn = (query: QueryDef) => Promise<void>;
2021
export type QueryHandlerFn = (query: QueryDef, cancelHandler: CancelHandlerFn) => Promise<unknown>;
@@ -29,7 +30,7 @@ export type ExecuteInQueueOptions = Omit<AddToQueueOptions, 'queueId'> & {
2930
};
3031

3132
export type QueryQueueOptions = {
32-
cacheAndQueueDriver: string;
33+
cacheAndQueueDriver: CacheAndQueryDriverType;
3334
logger: (message, event) => void;
3435
sendCancelMessageFn?: SendCancelMessageFn;
3536
sendProcessMessageFn?: SendProcessMessageFn;

packages/cubejs-query-orchestrator/test/unit/QueryCache.abstract.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export type QueryCacheTestOptions = QueryCacheOptions & {
88
afterAll?: () => Promise<void>,
99
};
1010

11-
export const QueryCacheTest = (name: string, options?: QueryCacheTestOptions) => {
11+
export const QueryCacheTest = (name: string, options: QueryCacheTestOptions) => {
1212
describe(`QueryQueue${name}`, () => {
1313
const cache = new QueryCache(
1414
crypto.randomBytes(16).toString('hex'),
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import { QueryCacheTest } from './QueryCache.abstract';
22

3-
QueryCacheTest('Local');
3+
QueryCacheTest('Local', {
4+
cacheAndQueueDriver: 'memory',
5+
});
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { QueryQueueTest } from './QueryQueue.abstract';
22

33
QueryQueueTest('Local', {
4-
cacheAndQueueDriver: 'local',
4+
cacheAndQueueDriver: 'memory',
55
});

0 commit comments

Comments
 (0)