Skip to content

Commit 7b60c03

Browse files
committed
remove unused: redisPrefix from PreAggregationLoader & PreAggregationPartitionRangeLoader
1 parent 6e7f7b2 commit 7b60c03

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

packages/cubejs-query-orchestrator/src/orchestrator/PreAggregations.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,6 @@ export class PreAggregationLoader {
525525
private externalRefresh: boolean;
526526

527527
public constructor(
528-
private readonly redisPrefix: string,
529528
private readonly driverFactory: DriverFactory,
530529
private readonly logger: any,
531530
private readonly queryCache: QueryCache,
@@ -588,7 +587,7 @@ export class PreAggregationLoader {
588587
: undefined,
589588
};
590589
} else {
591-
// Case 3: pre-agg is exists
590+
// Case 3: pre-agg exists
592591
const structureVersion = getStructureVersion(this.preAggregation);
593592
const getVersionsStarted = new Date();
594593
const { byStructure } = await this.loadCache.getVersionEntries(this.preAggregation);
@@ -619,7 +618,7 @@ export class PreAggregationLoader {
619618
}
620619

621620
if (versionEntryByStructureVersion) {
622-
// this triggers an asyncronous/background load of the pre-aggregation but immediately
621+
// this triggers an asynchronous/background load of the pre-aggregation but immediately
623622
// returns the latest data it already has
624623
this.loadPreAggregationWithKeys().catch(e => {
625624
if (!(e instanceof ContinueWaitError)) {
@@ -1520,7 +1519,6 @@ export class PreAggregationPartitionRangeLoader {
15201519
protected compilerCacheFn: <T>(subKey: string[], cacheFn: () => T) => T;
15211520

15221521
public constructor(
1523-
private readonly redisPrefix: string,
15241522
private readonly driverFactory: DriverFactory,
15251523
private readonly logger: any,
15261524
private readonly queryCache: QueryCache,
@@ -1684,7 +1682,6 @@ export class PreAggregationPartitionRangeLoader {
16841682
if (this.preAggregation.partitionGranularity && !this.preAggregation.expandedPartition) {
16851683
const loadPreAggregationsByPartitionRanges = async ({ buildRange, partitionRanges }: PartitionRanges) => {
16861684
const partitionLoaders = partitionRanges.map(range => new PreAggregationLoader(
1687-
this.redisPrefix,
16881685
this.driverFactory,
16891686
this.logger,
16901687
this.queryCache,
@@ -1766,7 +1763,6 @@ export class PreAggregationPartitionRangeLoader {
17661763
};
17671764
} else {
17681765
return new PreAggregationLoader(
1769-
this.redisPrefix,
17701766
this.driverFactory,
17711767
this.logger,
17721768
this.queryCache,
@@ -2207,7 +2203,6 @@ export class PreAggregations {
22072203
const preAggregationsTablesToTempTablesPromise =
22082204
preAggregations.map((p: PreAggregationDescription, i) => (preAggregationsTablesToTempTables) => {
22092205
const loader = new PreAggregationPartitionRangeLoader(
2210-
this.redisPrefix,
22112206
() => this.driverFactory(p.dataSource || 'default'),
22122207
this.logger,
22132208
this.queryCache,
@@ -2316,7 +2311,6 @@ export class PreAggregations {
23162311

23172312
const expandedPreAggregations: PreAggregationDescription[][] = await Promise.all(preAggregations.map(p => {
23182313
const loader = new PreAggregationPartitionRangeLoader(
2319-
this.redisPrefix,
23202314
() => this.driverFactory(p.dataSource || 'default'),
23212315
this.logger,
23222316
this.queryCache,
@@ -2360,7 +2354,6 @@ export class PreAggregations {
23602354
preAggregation, preAggregationsTablesToTempTables, newVersionEntry, requestId, invalidationKeys, buildRangeEnd
23612355
} = q;
23622356
const loader = new PreAggregationLoader(
2363-
this.redisPrefix,
23642357
() => this.driverFactory(dataSource),
23652358
this.logger,
23662359
this.queryCache,

0 commit comments

Comments
 (0)